Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Shiqi Yang committed Sep 25, 2019
1 parent aba7b48 commit d7514d0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@ Default to `undefined`.

`restrict` - *Boolean*

*** To be deprecated, see `signature-flags` *** Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.
**To be deprecated, see `signature-flags`.**
Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.

`signature-flags` - *String|String[]*
comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default is `undefined`
`signature-flags` - *String*
Comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default to `underfined`

`strict-verify` - *Boolean|String|Array.<String>*

Expand Down
3 changes: 2 additions & 1 deletion bin/electron-osx-sign-usage.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ DESCRIPTION
Specify the criteria that you recommend to be used to evaluate the code signature.

--restrict
Flag to enable restrict mode. Disabled by default. (this will be deprecated soon, see --sign-flags)
(This will be deprecated soon, see --sign-flags.)
Flag to enable restrict mode. Disabled by default.

--signature-flags=flags
Code signature flags. Default to none.
Expand Down
4 changes: 1 addition & 3 deletions sign.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ function signApplicationAsync (opts) {
optionsArguments = [...opts['signature-flags']]
} else {
const flags = opts['signature-flags'].split(',').map(function (flag) { return flag.trim() })
flags.forEach(element => {
optionsArguments.push(element)
})
optionsArguments = [...flags]
}
}

Expand Down

0 comments on commit d7514d0

Please sign in to comment.