app.stop hangs if node integration is disabled

[hacdias]

Hey!

We have an application with two windows and one of them has nodeIntegration set to false. Then, when calling app.stop on the tests, it just hangs and isn't able to close the application.

Although, if I enable node integrations, everything works as expected. Right now, we're just using this snipped (nodeIntegration: process.env.NODE_ENV === 'test') so our tests pass.

I wonder if this is the expected behavior or not. I took a look at your docs about this but couldn't find anything regarding this matter.

[lt-mayonesa]

Hey! same issue here, it seems to be expected behavior. When calling Application.stop() the following happens:

   if (self.api.nodeIntegration) {
      self.client.windowByIndex(0).electron.remote.app.quit().then(endClient, reject)
    } else {
      self.client.windowByIndex(0).execute(function () {
        window.close()
      }).then(endClient, reject)
    }

https://github.com/electron/spectron/blob/f741ee1f47d2983d948bdadeba263e9a7957d4eb/lib/application.js#L72

I ended up using the same work around as you