Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing with a certificate from the Cert Store (rather than a pfx file) #150

Open
toschlog opened this issue Feb 2, 2022 · 1 comment
Open

Comments

@toschlog
Copy link

toschlog commented Feb 2, 2022

I appears that it's not possible to sign the appx package using a cert from your local cert store or from a USB token.

I think this would be easy to fix. I suggest adding a config param called devCertSha1. If this is set, then instead of doing

signtool sign -f <program.devCert> -fd SHA256 -v <appxFile>

the app would do

signtool sign -sha1 <program.devCertSha1> -fd SHA256 -v <appxFile>

If this sounds reasonable, I'll make the changes, test it, and put in a pull reqeust.

@rickymohk
Copy link

rickymohk commented Dec 22, 2023

Opening up the options for custom signtool.exe and custom parameters, or sign with hook functions, just like how @electron/windows-sign does would also be great. I would like to sign using azure key vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants