Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn doesn't recognize 'rebuild' command #870

Closed
ConorIA opened this issue Nov 2, 2016 · 2 comments
Closed

yarn doesn't recognize 'rebuild' command #870

ConorIA opened this issue Nov 2, 2016 · 2 comments

Comments

@ConorIA
Copy link

ConorIA commented Nov 2, 2016

  • Version: 7.18.0
  • Target: Linux x64, unpacked dir

I was playing around to see if I could get yarn to work with electron-builder. However, if the builder decides to run rebuild, the command fails with an unknown command error. This is because yarn understands 'install --force' instead of 'rebuild'.

I tried simply replacing the term "rebuild" in electron-builder/out/build-cli.js with "install --force", but it still gives an error. However, if I replace the commands with "install" without the flag, I get passed that error and hit the '--cache-min' error that was fixed in a recent commit.

EDIT: Just noticed the dependency issue that you highlighted in #861. I can close this if it is an issue that needs to be fixed on the yarn side.

build --linux --x64 
Rebuilding app dependencies for arch x64 to /home/conor/git/wire-desktop/electron

Error: /usr/bin/node exited with code 1
Output:
yarn rebuild v0.16.1

Error output:
error Command "rebuild" not found.

    at ChildProcess.childProcess.once.code (/home/conor/git/wire-desktop/node_modules/electron-builder/src/util/util.ts:160:14)
    at ChildProcess.g (events.js:291:16)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
From previous event:
    at spawn (/home/conor/git/wire-desktop/node_modules/electron-builder/src/util/util.ts:123:3)
    at spawnNpmProduction (/home/conor/git/wire-desktop/node_modules/electron-builder/src/util/util.ts:49:3)
    at installDependencies (/home/conor/git/wire-desktop/node_modules/electron-builder/src/util/util.ts:20:122)
    at /home/conor/git/wire-desktop/node_modules/electron-builder/src/packager.ts:244:17
From previous event:
    at Packager.installAppDependencies (/home/conor/git/wire-desktop/node_modules/electron-builder/out/packager.js:343:11)
    at /home/conor/git/wire-desktop/node_modules/electron-builder/src/packager.ts:127:20
    at next (native)
From previous event:
    at Packager.doBuild (/home/conor/git/wire-desktop/node_modules/electron-builder/out/packager.js:254:11)
    at /home/conor/git/wire-desktop/node_modules/electron-builder/src/packager.ts:102:32
    at next (native)
    at runCallback (timers.js:637:20)
    at tryOnImmediate (timers.js:610:5)
    at processImmediate [as _immediateCallback] (timers.js:582:5)
From previous event:
    at Packager.build (/home/conor/git/wire-desktop/node_modules/electron-builder/out/packager.js:206:11)
    at /home/conor/git/wire-desktop/node_modules/electron-builder/src/builder.ts:234:33
    at next (native)
From previous event:
    at build (/home/conor/git/wire-desktop/node_modules/electron-builder/out/builder.js:81:21)
    at Object.<anonymous> (/home/conor/git/wire-desktop/node_modules/electron-builder/out/build-cli.js:66:41)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3
error Command failed with exit code 255.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@ConorIA ConorIA changed the title yarn doesn't recognize 'rebuild' command; needs 'install --force' yarn doesn't recognize 'rebuild' command Nov 2, 2016
@ConorIA
Copy link
Author

ConorIA commented Nov 3, 2016

Just saw the option to disable npmRebuild. This solves my issue for now.

@ConorIA ConorIA closed this as completed Nov 3, 2016
@develar
Copy link
Member

develar commented Nov 3, 2016

Yarn will be not supported until yarnpkg/yarn#756 is not fixed or rebuild will be not implemented on our side.

Duplicates #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants