Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMG background resource does not work if projectDir set #858

Closed
lishid opened this issue Oct 28, 2016 · 2 comments · May be fixed by qcif/data-curator#563
Closed

DMG background resource does not work if projectDir set #858

lishid opened this issue Oct 28, 2016 · 2 comments · May be fixed by qcif/data-curator#563

Comments

@lishid
Copy link

lishid commented Oct 28, 2016

  • Version: 7.14.2
  • Target: OSX(DMG)

When using a projectDir that's different than current directory ("."), specifying a dmg background causes an exception (Error: ENOENT: no such file or directory, lstat 'resources/osx/dmg-background.png').

Code below refers to file https://github.com/electron-userland/electron-builder/blob/master/src/targets/dmg.ts

The root cause seems to be from line 30
await copy(specification.background!, path.join(backgroundDir, backgroundFilename))

Looking at how the dmg icon resource is processed, we notice that it uses path.resolve(packager.projectDir, specification.icon) to find the resource. Maybe that should have been used?

@develar
Copy link
Member

develar commented Oct 28, 2016

Fix will be released in 20 minutes. Thanks for clear report.

@develar
Copy link
Member

develar commented Oct 28, 2016

Fixed in 7.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants