Make packager handle available native deps when building on non-native platforms #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyssdod, thanks for your PR! By analyzing the history of the files in this pull request, we identified @develar and @demetris-manikas to be potential reviewers. |
|
Commit message is kinda confusing, I meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Given the skip build flag handling you've merged previously, I was able to successfully use precompiled binaries when creating package for native platform. However, I've stumbled upon an issue when I was trying to package app with native deps for Windows on Mac. It just skipped deps installation and wrapped stuff I've got after initial
npm install(Mac-related) into Windows build, which of course didn't run. This change should allow the making of a truly crossplatform build on the same machine.