Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows NSIS Installer license is cut off at 126 Byte #8294

Closed
philkrpp opened this issue Jul 4, 2024 · 3 comments · Fixed by #8314
Closed

Windows NSIS Installer license is cut off at 126 Byte #8294

philkrpp opened this issue Jul 4, 2024 · 3 comments · Fixed by #8314

Comments

@philkrpp
Copy link

philkrpp commented Jul 4, 2024

  • Electron-Builder Version: 24.13.3 but also tested with latest alpha and also older versions
  • Node Version: tested in 20.9.0/20.11.1/16
  • Electron Version: 31.1.0 and also tried other electron versions
  • Electron Type (current, beta, nightly): current
  • Target: Windows NSIS

Hello all,

in our latest Windows NSIS installer I recognized that the license page does not contain whole content. It is always cut off when I am building on macOS at 126 Bytes. When I am building on Windows it seems to be fine with length but special characters (like in German äöü) are only displayed in cryptic characters.

macOS Sonoma 14.5 (MacMini i7 and also Mac Studio M2 Pro Max tested)
Windows 11 Pro 23H2 22631.3810 x86

Does anyone faces same issue?

Here is simple code for reproduction:
electron-builder-test.zip

macOS Build:
CleanShot 2024-07-04 at 08 05 59

Windows Build:
CleanShot 2024-07-04 at 08 10 05

@orlv
Copy link

orlv commented Jul 9, 2024

Hello,
have you found a solution?

@philkrpp
Copy link
Author

Unfortunately not yet. My workaround is to build macOS on macOS and Windows on Windows. I replaced all special characters like "Ä" to "Ae" and build the new version...

@beyondkmp
Copy link
Collaborator

@philkrpp For Windows Build, If we change license file's encode to utf-8 with bom, it works well.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants