Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Sign with Mac Developer certificates #812

Closed
vtardia opened this issue Oct 10, 2016 · 16 comments · May be fixed by qcif/data-curator#563
Closed

Code Sign with Mac Developer certificates #812

vtardia opened this issue Oct 10, 2016 · 16 comments · May be fixed by qcif/data-curator#563

Comments

@vtardia
Copy link

vtardia commented Oct 10, 2016

  • Version: 7.11.3
  • Target: macOS

Hi, with electron-builder 3 I was able to sign my app previews with my "Mac Developer" certificate. I've updated to 7 and I'm no longer able to do this, and I have to disable signing and manually sign with codesign.

Why? Can you put back this feature?

@develar
Copy link
Member

develar commented Oct 10, 2016

Why? Can you put back this feature?

You must not use this certificate type. Please see #740 and https://developer.apple.com/library/content/documentation/IDEs/Conceptual/AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html

Mac Developer – Used to enable certain app services for a Mac app during development and testing.

So, you must use Developer ID ApplicationUsed to sign a Mac app before distributing it outside the Mac App Store.

@vtardia
Copy link
Author

vtardia commented Oct 10, 2016

I'm familiar with both #740 and Apple guidelines, but I still need to be able to use Mac Developer certificates for development and testing, and let my client(s) use Developer IDs for distribution...

@develar develar reopened this Oct 10, 2016
@develar
Copy link
Member

develar commented Oct 10, 2016

Could you please explain me, why you cannot use Developer ID cert? Why Mac Developer is required?

@vtardia
Copy link
Author

vtardia commented Oct 10, 2016

Because as far as I know "Developer ID" is currently available only for paid plans

@develar
Copy link
Member

develar commented Oct 10, 2016

as far as I know "Developer ID" is currently available only for paid plans

Sorry, I don't understand. Any Apple cert requires Apple Developer account — in any case you have to pay for developer account and any cert is free for you.

@vtardia
Copy link
Author

vtardia commented Oct 10, 2016

With an Apple ID you can have free membership and a Mac Developer certificate for testing https://developer.apple.com/support/compare-memberships/. I develop and test with my free account and certificate, and my clients sign with their paid membership certificates.

@develar
Copy link
Member

develar commented Oct 10, 2016

Certificate will be allowed.

@vtardia
Copy link
Author

vtardia commented Oct 10, 2016

Thank you very much @develar!

@develar develar changed the title Signign with Mac Developer certificates Code Sign with Mac Developer certificates Oct 31, 2016
@ghost
Copy link

ghost commented Jan 10, 2017

Hi @develar, does it implemented/fixed? Still can't sign with "Mac Developer" cert.

Cert is correctly listed here: security find-identity -v

@develar
Copy link
Member

develar commented Jan 10, 2017

@cumajkeee What version of electron-builder do you use?
Please set env DEBUG=electron-builder and attach log of the terminal output.

@ghost
Copy link

ghost commented Jan 10, 2017

@develar:
v=11.2.3

Tue, 10 Jan 2017 14:12:26 GMT electron-builder Executing security find-identity -v
Tue, 10 Jan 2017 14:12:26 GMT electron-builder Executing security find-identity -v -p codesigning
Error: Identity name "Mac Developer: [email protected] (URxxxxxxxx)" is specified, but no valid identity with this name in the keychain
at /{path}/electron/node_modules/electron-builder/src/codeSign.ts:226:13
From previous event:

screenshot 2017-01-10 17 16 11

@develar
Copy link
Member

develar commented Jan 11, 2017

@cumajkeee if you specify identity manually, you should specify only name, without type prefix.

@ericzhangjx
Copy link

@develar
Actually doing so could also cause Error:

Packaging for darwin x64 using electron 1.4.14 to dist/Mac
Error: Identity name "[email protected] (QWERT12345)" is specified, but no valid identity with this name in the keychain
    at /Users/Eric/WorkSpace/PROJECT/node_modules/electron-builder/src/codeSign.ts:226:13

node: v=7.4.0
npm: v=4.0.5
electron-builder: v=11.2.4

@ericzhangjx
Copy link

#1103
Seems to have solved the problem (by removing an unnecessary exception inside findIdentity()).

@develar
Copy link
Member

develar commented Jan 12, 2017

Fixed in upcoming 11.2.4 (thanks to @ericzhangjx).

@ghost
Copy link

ghost commented Jan 13, 2017

Thanks @ericzhangjx and @develar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants