Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows App Doesn't Start / Shortcut Links Broken (after successful installation) #800

Closed
dharders opened this issue Oct 7, 2016 · 3 comments · May be fixed by qcif/data-curator#563
Closed

Comments

@dharders
Copy link

dharders commented Oct 7, 2016

  • Version: 7.11.2
  • Target: NSIS Windows

Just updated to latest electron-builder 7.11.2 and successfully built a Win64 NSIS target on Windows 7 (no errors/warnings given).

After running the setup.exe, I noticed the app did not auto-launch after installation. So I went to manually open the link on the desktop (and menu) and found they were broken links.

I managed to trace it back to something was released in version 7.11.1, as 7.11.0 does work (if I simply change my package.json version and npm install then build).

Looking at your release notes (and commits) it's not too obvious to me what in fact is the cause.

I've attached some relevant details below.

"electron-builder": "7.11.2",
"electron-prebuilt": "1.4.3",
"build": {
    ...
    "asar": true,
    "compression": "store",
    "npmRebuild": false,
    "win": {
      "target": "nsis",
      "certificateSubjectName": "My Cert",
      "iconUrl": "https://www.example.com.au/app.ico",
      "legalTrademarks": "Example™"
    },
    "mac": {
      "target": "dmg"
    },
    "nsis": {
      "perMachine": false,
      "allowElevation": true,
      "oneClick": true,
      "language": "3081"
    }
  }
@popod
Copy link
Contributor

popod commented Oct 7, 2016

Same thing for me using NSIS installer on windows 8 / 32bits OS. All shortcut are without app icon and broken.

@lbssousa
Copy link

lbssousa commented Oct 7, 2016

I've noticed the problem here. The issue is that generated NSIS package are installing files at App\Version\win-*-unpacked rather than App\Version as before, but generated shortcut tries to launch App\Version\App.exe.

I suppose the original intention of the project is to install files at App\Version, thus the behaviour observed at version 7.11.2, I mean, installing files at App\Version\win-*-unpacked, should be a regression.

@dharders dharders changed the title Windows App Doesn't Start / Shortcut Links Missing (after successful installation) Windows App Doesn't Start / Shortcut Links Broken (after successful installation) Oct 7, 2016
@develar develar closed this as completed in 993dac7 Oct 7, 2016
@develar
Copy link
Member

develar commented Oct 7, 2016

@lbssousa Thanks. And sorry for regression. Missed tests will be added later (it was not tested :(), for now I have fixed error. Fixed version will be released in 10 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants