Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.files won't work as expected #701

Closed
just-jeb opened this issue Aug 25, 2016 · 3 comments · May be fixed by qcif/data-curator#563 or Omrisnyk/trinity-wallet#88
Closed

build.files won't work as expected #701

just-jeb opened this issue Aug 25, 2016 · 3 comments · May be fixed by qcif/data-curator#563 or Omrisnyk/trinity-wallet#88
Labels

Comments

@just-jeb
Copy link

  • 5.34.1:
  • 1.3.4:

I would expect that if I specify "files": ["*.js"], it would include all the .js files in the app folder and its subfolders (similarly to find -name) into the build. However it includes only .js files in the app folder (won't include the subfolders).
Specifying "files": ["**/*.js"] causes electron-builder to include the whole app folder into the build (i.e. the same as specifying "files": ["**/*"]).
Both options appear to not work in a right way, so I suppose there is a bug here.

@develar
Copy link
Member

develar commented Aug 27, 2016

screen shot 2016-08-27 at 16 41 06

@just-jeb
Copy link
Author

just-jeb commented Sep 7, 2016

This particular issue has been fixed. Still a problem here: empty directories (that are not specified in build.files) are being copied.
To reproduce:

  • Checkout this repo
  • Run npm dist:*whatever*
  • Find the dist directory - there are empty directories that are not specified in the build.files (in plugins\native\precompiled-library)

@develar
Copy link
Member

develar commented Sep 8, 2016

@meltedspark Filed as #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants