Sharp library is not being unpacked

[andirsun]

• Electron-Builder Version:
  version=23.0.9

• Node Version:
   v14.19.0

• Electron Version:
  ^18.1.0
• Electron Type (current, beta, nightly):
  Current

• Target:
  Mac / Linux / Windows

I am using the sharp library and the library is being unpacked correctly on windows and mac os builds but I have to manually unpack the library on linux with this code

linux:
  category: Graphics
  # Linux fix to use sharp library
  asarUnpack:
    - "**/node_modules/sharp/**"

[andirsun]

I just donate to electron-builder org, thanks for helping me with this bug.

[mmaietta]

Can you please provide a minimum reproducibles repo using electron-quick-start?
I don't have a Linux machine available to test with but I'll do my best to debug it.
Glad you're able to use a workaround in the interim with asarUnpack

[andirsun]

@mmaietta Let me work on it, meanwhile this the error without the workaround of unpack the library

❯ snap run streamline
A JavaScript error occurred in the main process
Uncaught Exception:
Error: 
Something went wrong installing the "sharp" module

libvips-cpp.so.42: cannot open shared object file: No such file or directory

Possible solutions:
- Install with the --verbose flag and look for errors: "npm install --ignore-scripts=false --verbose sharp"
- Install for the current linux-x64 runtime: "npm install --platform=linux --arch=x64 sharp"
- Consult the installation documentation: https://sharp.pixelplumbing.com/install
    at Object.<anonymous> (/snap/streamline/x1/resources/app.asar/node_modules/sharp/lib/sharp.js:31:9)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:829:12)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13343)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/snap/streamline/x1/resources/app.asar/node_modules/sharp/lib/constructor.js:8:1)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)

[andirsun]

@mmaietta Our m1 users are reporing errors on mac os universal builds as well.

Uncaught Exception:
Error: 
Something went wrong installing the "sharp" module

dlopen(/Applications/Streamline.app/Contents/Resources/app.asar.unpacked/node_modules/sharp/build/Release/sharp-darwin-arm64v8.node, 0x0001): Library not loaded: @rpath/libvips-cpp.42.dylib
Referenced from: /Applications/Streamline.app/Contents/Resources/app.asar.unpacked/node_modules/sharp/build/Release/sharp-darwin-arm64v8.node
Reason: tried: '/Applications/Streamline.app/Contents/Resources/app.asar.unpacked/node_modules/sharp/build/Release/../.././vendor/8.12.2/darwin-arm64v8/lib/libvips-cpp.42.dylib' (no such file), '/Applications/Streamline.app/Contents/Resources/app.asar.unpacked/node_modules/sharp/build/Release/../.././vendor/8.12.2/darwin-arm64v8/lib/libvips-cpp.42.dylib' (no such file), '/Applications/Streamline.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libvips-cpp.42.dylib' (no such file), '/Applications/Streamline.app/Contents/MacOS/../Frameworks/libvips-cpp.42.dylib' (no such file), '/usr/lib/libvips-cpp.42.dylib' (no such file)

Possible solutions:
- Install with the --verbose flag and look for errors: "npm install --ignore-scripts=false --verbose sharp"
- Install for the current darwin-arm64v8 runtime: "npm install --platform=darwin --arch=arm64v8 sharp"
- Consult the installation documentation: https://sharp.pixelplumbing.com/install
at Object.<anonymous> (/Applications/Streamline.app/Contents/Resources/app.asar/node_modules/sharp/lib/sharp.js:31:9)
at Module._compile (node:internal/modules/cjs/loader:1116:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
at Module.load (node:internal/modules/cjs/loader:988:32)
at Module._load (node:internal/modules/cjs/loader:829:12)
at Function.c._load (node:electron/js2c/asar_bundle:5:13343)
at Module.require (node:internal/modules/cjs/loader:1012:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object.<anonymous> (/Applications/Streamline.app/Contents/Resources/

[mmaietta]

Automatic analysis (and copying) of modules is in upstream dependency https://github.com/develar/app-builder
I believe the code is found here: https://github.com/develar/app-builder/blob/master/pkg/node-modules/nodeModuleCollector.go

This can not be fixed solely through electron-builder, so you'll need to specifically it in asarUnpack to force unpack it

[goforu]

Any workaround?

[andirsun]

You can use resvg instead of sharp library

[Adedoyin-Emmanuel]

Automatic analysis (and copying) of modules is in upstream dependency https://github.com/develar/app-builder I believe the code is found here: https://github.com/develar/app-builder/blob/master/pkg/node-modules/nodeModuleCollector.go

This can not be fixed solely through electron-builder, so you'll need to specifically it in asarUnpack to force unpack it

@andirsun please how do specify it in asarUnpack to force unpack it, i am using electron-react.

Here is the build property in the package.json

"build": { "productName": "Fotograph", "appId": ".app.vercel.fotograph", "asar": true, "asarUnpack": "**\\*.{node,dll}", ...others}

[Adedoyin-Emmanuel]

"/node_modules/sharp/"

Automatic analysis (and copying) of modules is in upstream dependency https://github.com/develar/app-builder I believe the code is found here: https://github.com/develar/app-builder/blob/master/pkg/node-modules/nodeModuleCollector.go
This can not be fixed solely through electron-builder, so you'll need to specifically it in asarUnpack to force unpack it

@andirsun please how do specify it in asarUnpack to force unpack it, i am using electron-react.

Here is the build property in the package.json

"build": { "productName": "Fotograph", "appId": ".app.vercel.fotograph", "asar": true, "asarUnpack": "**\\*.{node,dll}", ...others}

After making some researches and testing it, this worked for me

"asarUnpack": [ "**\\*.{node,dll}", "**/node_modules/sharp/**" ],

[MarshallChang]

Please See this : Adedoyin-Emmanuel/fotograph#1