-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node modules, that must be unpacked, are not detected automatically #6792
Comments
That sounds like a similar environment/situation as to what pnpm uses. The upstream package is https://github.com/develar/app-builder that parses the dependency tree to generate the list to copy. Unfortunately, it doesn't seem to handle symlinks AFAICT |
Which means it is unfixable or should I file yet another issue there? :D |
We are having the same problem: WowUp/WowUp#1125 Several other projects too actually, f.e. jitsi/jitsi-meet-electron#556 |
@mmaietta is there an issue tracking this symlink issue in app-builder? |
Not that I'm aware of, I don't manage that project. Please create an issue there with your details |
But the documentation says:
I don't see where in unpackDetector.ts it's detecting node modules to be unpacked. It appears to only detect .dll, .exe, .dylib. .so, ffprobe-static, ffmpeg-static, and binary files that don't have a ".". |
I'm having code signing issues because electron not unpacking node_modules nut.js/512 |
electron-builder does not unpack node modules in vector-im/element-desktop.
"asarUnpack": "**/*.node",
helps as a workaround. As far as I understand they "yarn link" those two node_modules from build directory to the project directory, which makes them symlinks instead of normal directories. Could this be preventing electron-builder from unpacking them?For your reference: element-hq/element-desktop#337
The text was updated successfully, but these errors were encountered: