Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing MAS build with "3rd Party Mac Developer Application" cert is broken #6621

Open
tseifried opened this issue Feb 7, 2022 · 4 comments

Comments

@tseifried
Copy link

  • Electron-Builder Version: 22.11.11 and newer
  • Node Version: 14
  • Electron Version: 17
  • Electron Type (current, beta, nightly): current
  • Target: mac:mas

A breaking change (#6105) was introduced with patch 22.11.11 that broke our CI pipeline. Before this change 3rd Party Mac Developer Application cert could be used for code signing - which has been and still is accepted for store submissions by Apple.

Error:
⨯ skipped macOS application code signing reason=cannot find valid "Apple Distribution" identity
However a valid 3rd Party Mac Developer Application cert is installed and available, but does not get picked up anymore.

Workaround: Pin electron-builder version to 22.11.10

@lukas2
Copy link

lukas2 commented Feb 10, 2022

confirm, we have the same problem. @tseifried thank you providing the workaround!

@idoodler
Copy link
Contributor

I am confused with the certificates:

  • Don't we need the 3rd Party Mac Developer Application and "3rd Party Mac Developer Installer" certs anymore?
  • Can we just use the Apple Distribution cert then?
    • If so we could tidy up our certificates and nuke the 3rd Party certs

@idoodler
Copy link
Contributor

Yesterday I upgraded to macOS 12.3. It looks like electron-builder 22.11.10 is not ready for it as Apple removed Python2 from the system.

Now I have basically locked myself out from building functional macOS apps :/

@idoodler
Copy link
Contributor

Nice, so here is my current building flow:

  • The following targets are build concurrent with the latest electron-builder (NSIS, Appx, dmg, dpkg)
  • mas is build using an npm alias for [email protected]
    • To work around the python issue on macOS 12.3 I use pyenv
    • As a config file I use a .js file that loads the .yml config file and removes the beforePack hook property (which is not yet supported in this version) and patches the mas target properties

Not my proudest solution, but it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants