Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native compilation doesn't happen if the package is using prebuilt (eg leveldown) #647

Closed
cosmosgenius opened this issue Aug 4, 2016 · 5 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@cosmosgenius
Copy link

[email protected]

OSX el capitan x64

My app directory package.json has a dependency to leveldown 1.4.0. Since leveldown is natively compiled, I was expecting install-app-deps to compile with electron-prebuilt deps on dev package.json. While installing leveldown, it uses prebuilt to download native binary instead of compiling.

Passing --build-from-source as args in the doSpawn function fixes the issues and compile with the correct version.

@cosmosgenius
Copy link
Author

Is there any update on this? or is there some option which can force a rebuild in such cases?

@develar
Copy link
Member

develar commented Aug 15, 2016

Is it possible to attach sample project?

@cosmosgenius
Copy link
Author

@cosmosgenius
Copy link
Author

What i am doing currently is modifying the npmExecArgs variable in spawnNpmProduction by adding --build-from-source to args list. Is there anyway to passing this args to install-app-deps? That would solve this issue.

@develar
Copy link
Member

develar commented Aug 20, 2016

Thanks for clear explanation and sample project. --build-from-source added by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants