Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure compiled app has same hash on different computers. #604

Closed
atypicalprogrammer opened this issue Jul 20, 2016 · 4 comments · May be fixed by qcif/data-curator#563
Closed

Make sure compiled app has same hash on different computers. #604

atypicalprogrammer opened this issue Jul 20, 2016 · 4 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@atypicalprogrammer
Copy link

atypicalprogrammer commented Jul 20, 2016

I notice in the node_modules directory (in app.asar), all package.json files have an "_args" array which contains as the second arguments a directory local to my system.

This way it's not possible for me to build the app on multiple computers, and get the same md5 hash from the resulting app executable. (Because location is different (other username), on another computer, for example).

Being able to verify the build on different computers is however very important. Can something be done about this?

@develar
Copy link
Member

develar commented Jul 20, 2016

It is an npm stuff. Well... I guess it is safe to get rid of these fields in the package.json on copy. But please don't expect that it will be fixed by me soon. Please send PR.

@atypicalprogrammer
Copy link
Author

Yes, should not be fixed by you but by NPM. I have already posted about it on their issue list (an issue already existed, it seems). For now, I'm using https://github.com/juanjoDiaz/removeNPMAbsolutePaths to remove it before distribution.

@develar
Copy link
Member

develar commented Jul 22, 2016

It is not easy to implement for ASAR. But makes sense. So, not moved to backlog.

@develar
Copy link
Member

develar commented Jul 29, 2016

For ASAR fixed only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants