Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraResources parent directory #597

Closed
atypicalprogrammer opened this issue Jul 18, 2016 · 14 comments
Closed

extraResources parent directory #597

atypicalprogrammer opened this issue Jul 18, 2016 · 14 comments
Labels

Comments

@atypicalprogrammer
Copy link

Is it not possible to go outside the current directory?

For .directories.app this is possible.

But for build.extraResources it seem not;

build.extraResources = ["../extra/**/*"]

@develar
Copy link
Member

develar commented Jul 18, 2016

extraResources relative to the project directory. Do you want to copy resources outside of project directory?

@atypicalprogrammer
Copy link
Author

This is my structure

Folder
-- Packager (contains electron-builder)
-- App
-- Extra

All these are separate git repo's, that's why I can't include them together. So yes, I want to copy resources outside of the packager directory.

@develar
Copy link
Member

develar commented Jul 18, 2016

And dev package.json in the Packager? Hmm... your setup is strange :) Why you cannot put App and Extra inside Packager (clone to subfolder)? Just add App and Extra to .gitignore file of Packager.

@atypicalprogrammer
Copy link
Author

atypicalprogrammer commented Jul 18, 2016

Seems easier like I have it now :-) Especially because others will want to download it and if they then have to move the other repo's (which work independently) inside the packager, it's just a mess.

@develar
Copy link
Member

develar commented Jul 18, 2016

FYI: My working project contains 8 inner git repositories :)

@atypicalprogrammer
Copy link
Author

Well actually it seems illogical. Now I have to package my App inside a Packager folder. That just doesn't make sense. But fine!

@develar
Copy link
Member

develar commented Jul 18, 2016

it seems illogical

Well... To build app, you need some non-production code. Your Packager acts as a meta-directory — logical for me.

@atypicalprogrammer
Copy link
Author

Ideally one should be able to run the packager from anywhere I want. That seems more logical. But that's just my humble opinion ;-)

@develar
Copy link
Member

develar commented Jul 18, 2016

Ideally one should be able to run the packager from anywhere I want.

You can, but extraResources should be in the project basedir ;) (location, where do you run / dev package.json is located). It can be fixed, but as there is an acceptable solution, it will be not fixed for now :)

@atypicalprogrammer
Copy link
Author

How about we can add resources in the app folder, but not have them in the asar? so it would be app/resources or something and they'd automatically be added as extra resources. Not in asar is what I need.

@develar
Copy link
Member

develar commented Jul 18, 2016

How about we can add resources in the app folder, but not have them in the asar?

Originally, it was implemented for 2 package.json scheme. So, extra resources is not filtered automatically. Will be fixed once will be an issue about it ;)

Why it is included if you have Extra not in the App?

@chr1gu
Copy link

chr1gu commented Oct 18, 2016

I have the same problem as @atypicalprogrammer because my application lives next to the packaging project. The application is a separate project used by other projects so I also think it should not live inside the packager directory :)

@develar
Copy link
Member

develar commented Oct 18, 2016

@chrigu-ebert Now you have extraFiles/extraResources/files — please see https://github.com/electron-userland/electron-builder/wiki/Options

@chr1gu
Copy link

chr1gu commented Oct 18, 2016

@develar woah thanks for the super fast response! I'll check it out! Seems to do the trick :)

Edit:
Works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants