Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable asar #595

Closed
amilajack opened this issue Jul 17, 2016 · 8 comments
Closed

Disable asar #595

amilajack opened this issue Jul 17, 2016 · 8 comments
Labels

Comments

@amilajack
Copy link

  • Version: 5.12.1
  • Target: macOS

How do I disable asar? Currently, I have the following in my package.json in the root directory of my project:

// package.json
"build": {
    "appId": "popcorn-time-desktop",
    "app-category-type": "public.app-category.video",
    "asar": false,
    "win": {
      "iconUrl": "https://cdn.rawgit.com/amilajack/popcorn-time-desktop/master/app/icons/app.ico"
    }
  },
@amilajack
Copy link
Author

I've also tried setting asar: false to asar: "false" but I got the same result

@amilajack
Copy link
Author

amilajack commented Jul 18, 2016

Here are the files in /dist/mac/MyApp.app/Contents/Resources:

drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 ar.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 bg.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 bn.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 ca.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 cs.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 da.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 de.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 el.lproj
-rw-r--r--   1 amila  staff   181K Jul 17 17:09 electron.asar
-rw-r--r--   1 amila  staff   1.7M Jul 17 17:09 electron.icns
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 en.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 en_GB.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 es.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 es_419.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 et.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 fa.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 fi.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 fil.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 fr.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 gu.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 he.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 hi.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 hr.lproj
drwxr-xr-x   2 amila  staff    68B Jul 17 17:09 hu.lproj

I'm assuming that this is the output of the asar: true option. Am I correct?

@develar
Copy link
Member

develar commented Jul 18, 2016

If asar: true, you will get app.asar in the /dist/mac/MyApp.app/Contents/Resources. If false, directory app.

@amilajack
Copy link
Author

amilajack commented Jul 20, 2016

Sorry for the late response. I am not getting the directory app in /dist/mac/MyApp.app/Contents/Resources. Instead, I am getting app.asar. Here's some of the directory's contents:

// many `lproj` files
drwxr-xr-x   2 amila  staff    68B Jul 20 02:31 de.lproj
-rw-r--r--   1 amila  staff   100M Jul 20 02:31 app.asar
-rw-r--r--   1 amila  staff   180K Jul 20 02:31 electron.asar
-rw-r--r--   1 amila  staff   1.7M Jul 20 02:31 electron.icns

@develar
Copy link
Member

develar commented Jul 20, 2016

I am sure that "asar": false in the build works. Strange.

@amilajack
Copy link
Author

Found out what the problem was. I was switching back and forth between "false" and false. My bad.

@amilajack
Copy link
Author

@develar Would this be considered a bug? JSON supports boolean literals. "asar": false doesn't work but "asar": "false" does.

@develar
Copy link
Member

develar commented Aug 1, 2017

Now both values should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants