Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage gets wrong icon #593

Closed
probonopd opened this issue Jul 17, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

AppImage gets wrong icon #593

probonopd opened this issue Jul 17, 2016 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@probonopd
Copy link

  • Version: master
  • Target: Linux AppImage

Getting an "On" icon. I don't think that is the actual icon of the app I am trying to package.

This is what I did:

# Install npm 6 and other prerequisites
curl -sL https://deb.nodesource.com/setup_6.x | sudo -E bash -
sudo apt-get install -y nodejs icnsutils graphicsmagick

REPO=ahdriel/thesis-lab

wget https://github.com/$REPO/archive/master.zip
unzip master.zip
cd *-master/

sed -i -e 's|"electron-builder": ".*",|"electron-builder": "next",|g' package.json

npm install
npm run dist -- --linux=AppImage

If the upstream app has no icon, then a more generic Electron icon should be used as a fallback.

@develar
Copy link
Member

develar commented Jul 18, 2016

Icon is not required for macOS/Windows, but required for Linux — it is wrong, should be fixed. The same warn should be produced and default Electron icon used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants