[auto-updater]: autoUpdater.download() downloads _and_ installs update

[UberMouse]

22.6.0

• Electron Version: 8.2.0
• Electron Type (current, beta, nightly): current

4.3.1

• macOS

I've integrated with the auto updater events in electron-builder to build my own auto-update UI. I have separate steps for downloading and installing the update. Which I am performing by calling autoUpdater.downloadUpdate() and autoUpdate.quitAndInstall() respectively.

However, it appears that as soon as the update is done downloading after calling downloadUpdate the update is installed. Is it possible to change this behaviour on macOS?

I see that there is the autoUpdater.autoInstallOnAppQuit setting to turn this off, but it doesn't support macOS.

Are there any alternatives here? How come I can't disable this functionality on macOS?

[UberMouse]

Related to #4308

[gre]

sadly a bot automatically closed the PR #4308 , we kept maintaining this PR to be mergeable for months and it was not merged yet and not even commented by the owners. I hope we have the opportunity to look at it and get it merged because it seems pretty relevant and important regarding implementing a secure update.

cc @MortalKastor @develar @atali

[UberMouse]

Seconded. I manually applied your PR with patch-package so at least one other company is using it! I can confirm it's been working without any problems for us.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[UberMouse]

This is still relevant. It's blocked on someone merging the PR in #4308

cc @develar

[gre]

Is there any way we can help on this topic @develar?
It is an important security-related topic, i'm not sure why is it ignored but we're here to help.

[gre]

@MortalKastor can you recreate the PR? I hope it's going to be reviewed this time..

[MortalKastor]

@gre OK

Third time's a charm, as the saying goes 🤞

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[UberMouse]

This is still relevant. It's blocked on someone merging the PR in #5271

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[gre]

YES

[bjbk]

Any resolution to this issue? There may be reasons for macOS users to delay update installs. Is there a roadmap outlining when autoInstallOnAppQuit = false will be properly implemented in the auto-updater?

[UberMouse]

There is no reason afaik. We use the patch from #5271 to get this functionality and it works fine with the patch applied. I'm not sure why it's never been merged other than the fact that electron-builder seems poorly maintained.

[bjbk]

Seems a shame. In so many ways I find it superior to electron-packager. Hopefully it will be merged.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.