Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differential update request is not timed out if it hangs #4618

Closed
clusterberries opened this issue Jan 27, 2020 · 0 comments
Closed

Differential update request is not timed out if it hangs #4618

clusterberries opened this issue Jan 27, 2020 · 0 comments

Comments

@clusterberries
Copy link
Contributor

  • Version: 21.1.5
  • electron-updater: 4.1.2
  • Target: nsis

Hello!
I faced with issue described here #3973
I added some more logs to electron-updated in order to understand why it is happening. The initial case is hard to define, but I found out that timeout should be set when request is created:

differentialDownloader.httpExecutor.addErrorAndTimeoutHandlers(request, reject);

(multipleRangeDownloader file)
But the request is never timed out, it just hangs.
I can create a PR with fix, but I am not sure how it should be fixed. @develar need you advice. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants