Update is downloaded but not installed, if application was installed for all users (in Program Files) on Windows

[DominikLevitsky]

• electron-builder:
  22.1.0

• electron-updater:
  4.2.0

• Target:
  nsis

Settings:

    "nsis": {
      "oneClick": false,
      "allowToChangeInstallationDirectory": true,
      "allowElevation": true,
      ...
     }

Steps to reproduce:

1. Build electron app, and put the version to lets say 1.0.0;
2. Build nsis target and artifacts for auto-update (latest.yml);
3. Build the app again, put the version to lets say 1.0.1, also build artifacts (latest.yml);
4. Upload the 1.0.1 version to your server, or wherever, just so 1.0.0 can see it;
5. Launch the 1.0.0 app. Wait for the update to download, app relaunches to update. So far so good.
6. Now, if the app was installed for single user (to C:/Users/User/AppData/Local/Programs/...) everything is fine, the app is uninstalled, then the 1.0.1 version is installed, all good.
   But if the app was installed for all users (to C:/Program Files/...) the UAC dialog launches, asking for permission (as expected), the app is uninstalled (as expected), but then it is not installed again (totally unexpected). No errors, no warning, no nothing.

I will be happy to provide any other info if needed.

[kzimny]

Indeed very strange. Can you try to start your exe from command line and see what happen in the console? Did you already try on another PC?

[DominikLevitsky]

@kzimny What exe and when exactly? The main app exe? Or the app installer exe? It installs totally fine to any location, when installed manually.

[DominikLevitsky]

Probably worth mentioning, the app-updater folder (in C:/Users/User/AppData/Local/app-updater/pending/update-info.json) has the property "isAdminRightsRequired": false, shouldn't it be set to true, actually, if the app is installed in the Program Files for all users?

[kzimny]

The exe file launch in step 5 from C:/Program Files/MyApp/myapp.exe.
Look at #4312. Maybe similar issue?

[DominikLevitsky]

Okay, running it as Administrator allows it to install properly. I think it is the same as #1129
@develar Can you look into this?

[damianobarbati]

@DominikLevitsky did you solve this?

Not sure is related but my NSIS installer just dies in the middle of installation progress, no matter if I run it as administrator. NB: it starts installing.
This is breaking my users auto-update (and causing an infinite loop of installations...).

How can I debug the NSIS installer created by electron-builder?

"nsis": {
    "oneClick": false,
    "perMachine": true,
    "allowElevation": true,
    "deleteAppDataOnUninstall": true,
}
...
"electron": "^7.1.3",
"electron-builder": "21.2.0",

[DominikLevitsky]

@damianobarbati We solved the install issue using this:

    "win": {
     ...
      "requestedExecutionLevel": "highestAvailable"
    }

But it seems like a temporary solution only, because now, it always asks for admin permission on every app opening, which is not acceptable. I wish someone could help to fix this.

[damianobarbati]

@DominikLevitsky thanks for helping. Unfortunately that's not working for me, the installer keep just dying.

[jypdapeng]

解决了吗？

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[adambailey-]

We also have this problem.

[Dysey]

some infos @adambailey- ? @damianobarbati

[rasgo-cc]

Same issue here. Anyone willing to work on this? Any useful pointers?

PS: I'm using "electron-builder": "^22.8.0" and "electron-updater": "^4.3.4"

[ajgassner]

I had the same issue when calling the updater with silent option: autoUpdater.quitAndInstall(true, true)
My workaround is to ask the win registry if my installation is machine-wide before calling quitAndInstall:

using https://github.com/ironSource/node-regedit

// there is an issue with silent update and machine wide installation, see https://github.com/electron-userland/electron-builder/issues/4474
// UUID is automatically generated from appId, so do not change appId!
const REGISTRY_KEY = 'HKLM\\SOFTWARE\\<<REMPLACE_ME_WITH_UNIQUE_APP_ID>>';
let silentUpdate = true;
regedit.setExternalVBSLocation('resources/regedit/vbs');
if (process.platform !== 'darwin') {
  regedit.list(REGISTRY_KEY, (error, result) => {
    if (error) {
      logger.info("no machine wide installation found");
      return;
    }
    if (result && result[REGISTRY_KEY] && result[REGISTRY_KEY].values && result[REGISTRY_KEY].values['InstallLocation']) {
      const machineWideInstallLocation = result[REGISTRY_KEY].values['InstallLocation'].value;
      if (path.dirname(app.getPath("exe")) === machineWideInstallLocation) {
        logger.info("machine wide installation found: " + machineWideInstallLocation);
        silentUpdate = false;
        return;
      }
    }
    logger.info("no machine wide installation found. no match");
  });
}

package.json:

"build": {
  "win": {
    "extraResources": [
      {
        "from": "app/node_modules/regedit/vbs",
        "to": "regedit/vbs",
        "filter": [
          "**/*"
        ]
      }
    ]
  },
...

then call autoUpdater.quitAndInstall(silentUpdate, true)

[majorgeek85]

Hi,

I have Electron-updater on 4.3.8 (last version), electron builder on 22.10.5 (last version) and I still have exactly the same problem as the OP.

Any pointers would be much appreciated.

Best Regards,
Nelson Oliveira

[ElectroBuddha]

Should be solved in electron-updater v4.6.5 by #6450

[veecam]

@damianobarbati We solved the install issue using this:

    "win": {
     ...
      "requestedExecutionLevel": "highestAvailable"
    }

But it seems like a temporary solution only, because now, it always asks for admin permission on every app opening, which is not acceptable. I wish someone could help to fix this.

Oh my godness, you saved me! It took me a whole day to find a solution until I saw your reply.

[saif-o99]

@DominikLevitsky did you solve this?

Not sure is related but my NSIS installer just dies in the middle of installation progress, no matter if I run it as administrator. NB: it starts installing. This is breaking my users auto-update (and causing an infinite loop of installations...).

How can I debug the NSIS installer created by electron-builder?

"nsis": {
    "oneClick": false,
    "perMachine": true,
    "allowElevation": true,
    "deleteAppDataOnUninstall": true,
}
...
"electron": "^7.1.3",
"electron-builder": "21.2.0",

i got the same issue as yours. how did you manage to fix it?

[saif-o99]

Anyone using nx and / or nx-electron. always check the package.json version inside dist folder.
sometimes the building process doesn't update it to latest which for me caused loop of causing an infinite loop of installations.