Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatch Issue #433

Closed
simonlast opened this issue May 23, 2016 · 4 comments
Closed

Version mismatch Issue #433

simonlast opened this issue May 23, 2016 · 4 comments
Labels

Comments

@simonlast
Copy link

simonlast commented May 23, 2016

I'm trying to build an electron app using electron builder. It seems to work, but the 'paste' event isn't being handled in the electron-builder version. It does work when I use the 'electron' command.

I took a screenshot of the behavior here:
(On the left is the electron-builder version, with no paste event. On the right is the 'electron' version. Both are running the same version of electron.)

image

These are the command line arguments I am using:

    --platform, darwin,
    --arch all
    --version 1.1.1
    --out ./build/static/desktop
    --overwrite
    --icon ./build/static/icon.icns
@develar
Copy link
Member

develar commented May 24, 2016

It seems you use old electron-builder version? Because --icon, --overwrite, --out and --version is not a CLI args in the 3.x ?

@simonlast
Copy link
Author

Oops, I put this issue on the wrong package! I got confused between electron builder and packager... 😬

@simonlast
Copy link
Author

OK, so I switched to using electron-builder, and still get the same issue.

It builds and runs properly, and displays the same version as if I had run it from 'electron', but clipboard events do not fire in the browser (copy, paste, etc.)

My code:

builder.build({
    platform    : [builder.Platform.OSX],
    devMetadata : {
        build: {
            "app-bundle-id"     : "notion.id",
            "app-category-type" : "Productivity"
        },
        directories: {
            "app"            : "build/desktop",
            "output"         : "build/static/desktop",
            "buildResources" : "build/static"
        },
    }
})
.then(() => {
    // handle result
    callback()
})
.catch((error) => {
    // handle error
    callback(error)
})

@simonlast simonlast reopened this May 24, 2016
@simonlast
Copy link
Author

I figured it out. It turns out I wasn't creating the menu properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants