Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload prerelease version #395

Closed
mbrainiac opened this issue May 12, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Cannot upload prerelease version #395

mbrainiac opened this issue May 12, 2016 · 7 comments · May be fixed by qcif/data-curator#563

Comments

@mbrainiac
Copy link
Contributor

Packaging app for platform win32 x64 using electron v0.37.8
Release v3.0.0-beta.2 doesn't exists, creating one
Error: ENOENT: no such file or directory, stat 'C:\projects\app\dist\win-x64\App-3.0.0-beta.2-full.nupkg'
    at Error (native)
From previous event:
    at GitHubPublisher.<anonymous> (C:\projects\app\node_modules\electron-builder\src\gitHubPublisher.ts:77:32)
    at [object Generator].next (native)
From previous event:
    at tsAwaiter (C:\projects\app\node_modules\electron-builder\src\awaiter.ts:10:47)
    at GitHubPublisher.upload (C:\projects\app\node_modules\electron-builder\src\gitHubPublisher.ts:69:51)
    at C:\projects\app\node_modules\electron-builder\src\builder.ts:80:72
From previous event:
    at EventEmitter.<anonymous> (C:\projects\app\node_modules\electron-builder\src\builder.ts:80:16)
    at emitOne (events.js:90:13)
    at EventEmitter.emit (events.js:182:7)
    at WinPackager.dispatchArtifactCreated (C:\projects\app\node_modules\electron-builder\src\platformPackager.ts:101:28)
    at WinPackager.<anonymous> (C:\projects\app\node_modules\electron-builder\src\winPackager.ts:178:12)
    at [object Generator].next (native)
    at tryOnImmediate (timers.js:534:15)
    at processImmediate [as _immediateCallback] (timers.js:514:5)
From previous event:
    at tsAwaiter (C:\projects\app\node_modules\electron-builder\src\awaiter.ts:10:47)
    at Object.build (C:\projects\app\node_modules\electron-builder\src\builder.ts:30:59)
    at Object.<anonymous> (C:\projects\app\node_modules\electron-builder\src\build-cli.ts:47:2)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:146:18)
    at node.js:404:3

The output file is App-3.0.0-beta2-full.nupkg, (no dot at beta), but the builder trying to upload file App-3.0.0-beta.2-full.nupkg.

@develar
Copy link
Member

develar commented May 12, 2016

electron-builder version?

@mbrainiac
Copy link
Contributor Author

3.20.0

@develar
Copy link
Member

develar commented May 12, 2016

How version is specified in your package.json?

@mbrainiac
Copy link
Contributor Author

My version is 3.0.0-beta.2,
I think the problem is winstaller-fixed removed the dot before creating nupkg, and git uploader use the file with version string from package.json.

@develar
Copy link
Member

develar commented May 12, 2016

It is a regression in the last release, fix in progress.

@develar
Copy link
Member

develar commented May 12, 2016

Does it work before?

@develar
Copy link
Member

develar commented May 12, 2016

   public string SuggestedReleaseFileName {
            get {
                var zp = new ZipPackage(InputPackageFile);
                return String.Format("{0}-{1}-full.nupkg", zp.Id, zp.Version);
            }
        }

winstaller-fixed behaviour correct according to *** Squirrel.Windows *** nuget *** transformation. electron-builder is not aware of such *** transformation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants