Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Last Quartet of Windows Store Version #3875

Closed
semireg opened this issue May 6, 2019 · 8 comments
Closed

Setting Last Quartet of Windows Store Version #3875

semireg opened this issue May 6, 2019 · 8 comments

Comments

@semireg
Copy link

semireg commented May 6, 2019

  • Version: 20.39.0
  • Target: win/appx

Thank you for this wonderful module. I've been successfully publishing my app to the Microsoft Store and Mac App Store (MAS). Huzzah!

Sending multiple builds of the same version to the MAS works fine by setting Mac --> "bundleVersion": "X0Y0Z00N" where app's version is X.Y.Z and the build number is logically N for that version.

Docs read, buildVersion String - The build version. Maps to the CFBundleVersion on macOS, and FileVersion metadata property on Windows. Defaults to the version.

Is this buildVersion string added to appx files? I started doing beta testing in the Microsoft Store. They recommend what they call a "Package flight" where you specify which user accounts get access to certain packages (appx). However, when I upload two of the "same" X.Y.Z.0 (different buildVersion, N) I get an error:

All .msix and .appx packages (including previously published and currently uploaded) must be uniquely identified by their full names. You have provided two packages with the full name SemiregIndustriesLLC.MyApp_X.Y.Z.0_X64_ which have different contents. Please remove one of these packages, or increment current package versions to continue.

I think we need to set the build number as the last portion of the appx version. Is there any way to change X.Y.Z.0 to X.Y.Z.N where N is the buildVersion?

@semireg
Copy link
Author

semireg commented May 9, 2019

This call to getVersionInWeirdWindowsForm gets handled here, which ignores the build version on purpose.

The easiest solution may be to remove the argument "false" from the call to getVersionInWeirdWindowsForm. It would be prudent to figure out why that was put there in the first place.

Thoughts?

@semireg
Copy link
Author

semireg commented May 9, 2019

Thanks to the GitHub link in the source I finally tracked down a conversation about this segment of code, #2635. 👍

Still need to figure out the best way to rectify this for appx, passing in false, etc...

@develar
Copy link
Member

develar commented May 9, 2019

Thanks for donation.

Well, it is so by intention — #2979

Interesting....

@semireg
Copy link
Author

semireg commented May 9, 2019

You're welcome! I really appreciate the work that's gone into this project.

Thanks for digging up the issue reference. More info the better. Time to open a ticket with Microsoft... 🎺

@develar
Copy link
Member

develar commented May 9, 2019

As you have donated and need some urgent solution, and as no one except MS guys can clear up this thing, I will just add option to force settings build number (in 1 hour).

@semireg
Copy link
Author

semireg commented May 9, 2019

That's appreciated so I can test, but I unfortunately expect MS to reject the app with the same error referenced in #2979. If you make that change I'll test and report back.

Btw, is there a guide on setting up a proper electron-builder dev environment? I forked the project, cloned on my machine, built using yarn compile and I'm unsure how to "install" the resulting npm module in my project. Is there a doc that clarifies that process? That way, I could do this change/testing myself. Self serve 🙌

@develar
Copy link
Member

develar commented May 9, 2019

setBuildNumber option is added to appx.

@develar
Copy link
Member

develar commented May 9, 2019

is there a guide on setting up a proper electron-builder dev environment

#2781 (comment)

In short — after yarn compile, you don't need to publish, just set NODE_PATH to force resolving of electron-builder to your local installation instead of installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants