You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've published version 0.0.1-beta.1 through 0.0.1-beta.9 of my app. Before publishing 0.0.1-beta.10 I launched and it found and tried to install 0.0.1-beta.9. Is this expected behavior?
Looking at isUpdateAvailable it seems getVersionPreleaseComponents (semver.prerelease) parses "beta.9" into an array consisting of ["beta", 9]. The equality check fails and the method falls through to return default true.
The more I read about semver and prerelease tags the more confused I am. When a channel is assigned via autoUpdater.channel = 'beta' it is hitting the update file beta-mac.yml. However, when it's comparing these prerelease components... shouldn't it instead be comparing the channel (1st element)?
if (currentVersionPrereleaseComponent === latestVersionPrereleaseComponent) {
// allowDowngrade taken in account only if channel differs
return isLatestVersionNewer
}
should be something like...
const currentChannel = currentVersionPrereleaseComponent[0]
const latestChannel = latestVersionPrereleaseComponent[0]
if (currentChannel === latestChannel) {
// allowDowngrade taken in account only if channel differs
return isLatestVersionNewer
}
I'm unsure how to test this, though. The electron-builder repo contains many other NPM packages... what is the npm command or package.json format to install electron-updater from a different repo?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I've published version 0.0.1-beta.1 through 0.0.1-beta.9 of my app. Before publishing 0.0.1-beta.10 I launched and it found and tried to install 0.0.1-beta.9. Is this expected behavior?
Looking at isUpdateAvailable it seems getVersionPreleaseComponents (semver.prerelease) parses "beta.9" into an array consisting of ["beta", 9]. The equality check fails and the method falls through to return default
true
.The more I read about semver and prerelease tags the more confused I am. When a channel is assigned via
autoUpdater.channel = 'beta'
it is hitting the update filebeta-mac.yml
. However, when it's comparing these prerelease components... shouldn't it instead be comparing the channel (1st element)?should be something like...
I forked the repo and committed this quick test/fix.
I'm unsure how to test this, though. The electron-builder repo contains many other NPM packages... what is the npm command or package.json format to install
electron-updater
from a different repo?This doesn't work:
I've also tried:
and then run
npm run compile
within../electron-builder
andnpm install
within../electron-builder/packages/electron-updater
.However, then I get this error when trying to
npm install
in my electron project:I've spent a few hours trying to update babel to 7, but I'm having all sorts of issues. 👎
The text was updated successfully, but these errors were encountered: