Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are binary patch updates available for mac? #3242

Closed
dsabanin opened this issue Aug 14, 2018 · 1 comment
Closed

Are binary patch updates available for mac? #3242

dsabanin opened this issue Aug 14, 2018 · 1 comment

Comments

@dsabanin
Copy link

dsabanin commented Aug 14, 2018

  • Version: electron-builder version 20.28.1 with electron 3.0.0-beta.5, but also tried with2.x versions of Electron. Node version is 10.2.1.

  • Target: MacOS 10.14 Beta (18A365a), but the same thing is happening on 10.13.

I'm using "electron-publisher-s3": "^20.17.2" and I've never seen binary patches being applied during updates on Mac. It always downloads the whole application archive from S3. My questions is, is it implemented and supposed to work? Am I doing something wrong? Any help is appreciated.

I do see the mention of the block map file in the logs, so it seems that it tries to do something for the incremental patch updates:

  • writing effective config file=dist/artifacts/builder-effective-config.yaml
  • rebuilding native production dependencies platform=darwin arch=x64
  • packaging       platform=darwin arch=x64 electron=3.0.0-beta.5 appOutDir=dist/artifacts/mac
  • signing         file=dist/artifacts/mac/MyApplication identityName=Developer ID Application: MyCompany, LLC (3F99YQGAN3) identityHash=C0BA6D93FF6F10F17981B64C3D8CB3C5810EDC18 provisioningProfile=none
  • building        target=macOS zip arch=x64 file=dist/artifacts/MyApplication-0.811.0-snapshot-mac.zip
  • building        target=DMG arch=x64 file=dist/artifacts/MyApplication-0.811.0-snapshot.dmg
  • building block map blockMapFile=dist/artifacts/MyApplication-0.811.0-snapshot.dmg.blockmap
  • publishing      publisher=S3 (bucket: com-my-application-s3)
  • uploading       file= MyApplication-0.811.0-snapshot.dmg.blockmap provider=S3
  • uploading       file= MyApplication-0.811.0-snapshot.dmg provider=S3
  • uploading       file= MyApplication-0.811.0-snapshot-mac.zip provider=S3
  • uploading       file=snapshot-mac.yml provider=S3
  • Config from package.json:
  "build": {
    "appId": "com.myapplication.bundle",
    "productName": "MyApplication",
    "asar": true,
    "buildDependenciesFromSource": true,
    "readonly": true,
    "forceCodeSigning": true,
    "protocols": [
      {
        "name": "MyApplication",
        "schemes": [
          "my-application"
        ],
        "role": "Editor"
      }
    ],
    "mac": {
      "category": "public.app-category.developer-tools",
      "type": "distribution",
      "extendInfo": {
        "NSAppSleepDisabled": true,
        "NSSupportsAutomaticTermination": true
      }
    },
    "directories": {
      "output": "./dist/artifacts"
    },
    "files": [
      "build"
    ],
    "publish": {
      "provider": "s3",
      "bucket": "com-my-application-s3"
    }
  }```
@develar
Copy link
Member

develar commented Nov 8, 2018

Duplicates #2995

@develar develar closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants