Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Skip Squirrel step #322

Closed
antelle opened this issue Apr 16, 2016 · 9 comments · May be fixed by qcif/data-curator#563
Closed

[Feature request] Skip Squirrel step #322

antelle opened this issue Apr 16, 2016 · 9 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@antelle
Copy link

antelle commented Apr 16, 2016

For apps that don't use Squirrel, that would be useful to completely skip Squirrel archives creation step at build. For example, by adding autoUpdate: false config option.

@develar
Copy link
Member

develar commented Apr 16, 2016

What do you want to get? Zip or just dir with exe?

@develar
Copy link
Member

develar commented Apr 16, 2016

Related to #279

@antelle
Copy link
Author

antelle commented Apr 16, 2016

I want to get installers without zip for auto-update.

@develar
Copy link
Member

develar commented Apr 16, 2016

Do you mean OS X or Windows?

@antelle
Copy link
Author

antelle commented Apr 16, 2016

Both. Currently my workflow is:

  1. package apps for OSX, Windows and Linux with electron-packager
  2. build installers for OSX and Windows with electron-builder (I'm on old version, v2.1)
  3. create a deb for linux myself

I'm switching to use new electron-builder (hope, it will allow to simplify steps 1 and 2), and I would like to get exe and dmg without additional step of building squirrel zip because I'm using own auto-update instead of squirrel.

@develar
Copy link
Member

develar commented Apr 16, 2016

Windows requires Squirrel, please see #279. I think, for you it is ok. Update zip is not created for Windows.

OS X is OS X — no problem here, it is not *** Windows. Got your request, should be a way to disable zip archive generation.

Linux — we can build deb.

Yes, new version should simplify your build — if not, blame me and feel free to file any issue.

@develar develar removed the windows label Apr 16, 2016
@develar
Copy link
Member

develar commented Apr 16, 2016

package apps for OSX, Windows and Linux with electron-packager

I hope it is clear — you do not need to use electron-packager directly anymore.

@develar
Copy link
Member

develar commented Apr 21, 2016

OS X: disable ZIP generation — set build.osx.target to ["dmg"] See https://github.com/electron-userland/electron-builder/wiki/Options#OsXBuildOptions-target

Windows: I think Squirrel is ok for you?

@antelle
Copy link
Author

antelle commented Apr 21, 2016

Thank you!
Yes, Squirrel for Windows is ok, I've switched the installer to using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants