Do not remove GitHub's releaseType attribute from the publish configuration #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because this publish config is used later directly in artifactCreated event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines cause an issue when publishing a build to GitHub with a
releaseTypeofprereleaseorrelease. When thelatest*.ymlfiles are published, the GitHub publisher fails to upload these files without thereleaseTypeoption, as thereleaseTypedefaults todraft, which does not match thereleaseTypeof the release and its executables.I realize that these may be here for a good reason, so this pull request should definitely be reviewed by someone that is more familiar with the publishing system (@develar).
Closes #2971.