-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can I set the OSX app icon? #289
Comments
It is a critical bug due to electron 0.37.4 Set electron-prebuilt version to "electron-prebuilt": "0.37.3" as temp workaround. See electron/packager#300 |
Does this mean actually use 0.37.3 as a workaround or just set the package.json to that but still really use a different version? |
@ccnokes It is already fixed (but you must use electron 0.37.4+). May be LinusU/node-appdmg#84 (comment) is your issue? |
@develar Ok, I'm using electron 0.37.8 and electron-builder 2.8.2 (I know, I'm on an old version) and was seeing the issue. So you think upgrading to the latest electron-builder will fix the issue for me or is something else going on? It looks like there's some breaking changes upgrading from 2.8.2 so I was hoping to avoid it if possible but I'll bite the bullet if needed. Thanks! |
@ccnokes yes, it is fixed in the 3.5.0+. |
I'm seeing this on builder 3.17.1 and electron 0.37.8. Is this a known issue? |
Is it possible to have separate icons for app and mounted dmg? I don't want the mounted dmg to have the same icon as the app. |
@nickdima |
great, thanks! |
The documentation only talks about the icon used for the .dmg, while the resulting application still has the electron default icon. How can I set the Icon for the App itself?
The text was updated successfully, but these errors were encountered: