Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I set the OSX app icon? #289

Closed
cajus opened this issue Apr 4, 2016 · 9 comments
Closed

How can I set the OSX app icon? #289

cajus opened this issue Apr 4, 2016 · 9 comments
Labels

Comments

@cajus
Copy link

cajus commented Apr 4, 2016

The documentation only talks about the icon used for the .dmg, while the resulting application still has the electron default icon. How can I set the Icon for the App itself?

@develar
Copy link
Member

develar commented Apr 4, 2016

It is a critical bug due to electron 0.37.4 Set electron-prebuilt version to "electron-prebuilt": "0.37.3" as temp workaround. See electron/packager#300

@develar develar added the mac label Apr 9, 2016
@develar develar closed this as completed Apr 9, 2016
@ccnokes
Copy link

ccnokes commented May 2, 2016

Set electron-prebuilt version to "electron-prebuilt": "0.37.3" as temp workaround

Does this mean actually use 0.37.3 as a workaround or just set the package.json to that but still really use a different version?

@develar
Copy link
Member

develar commented May 2, 2016

@ccnokes It is already fixed (but you must use electron 0.37.4+). May be LinusU/node-appdmg#84 (comment) is your issue?

@ccnokes
Copy link

ccnokes commented May 2, 2016

@develar Ok, I'm using electron 0.37.8 and electron-builder 2.8.2 (I know, I'm on an old version) and was seeing the issue. So you think upgrading to the latest electron-builder will fix the issue for me or is something else going on?

It looks like there's some breaking changes upgrading from 2.8.2 so I was hoping to avoid it if possible but I'll bite the bullet if needed.

Thanks!

@develar
Copy link
Member

develar commented May 2, 2016

@ccnokes yes, it is fixed in the 3.5.0+.

@framerate
Copy link

The documentation only talks about the icon used for the .dmg, while the resulting application still has the electron default icon. How can I set the Icon for the App itself?

I'm seeing this on builder 3.17.1 and electron 0.37.8. Is this a known issue?

@nickdima
Copy link

Is it possible to have separate icons for app and mounted dmg? I don't want the mounted dmg to have the same icon as the app.

@develar
Copy link
Member

develar commented Jun 14, 2016

@nickdima osx.icon is only and only DMG icon. So, just set it to path to icon.

@nickdima
Copy link

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants