Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not upload auto-update files for the second configured provider #2697

Closed
IGassmann opened this issue Mar 15, 2018 · 5 comments
Closed

Do not upload auto-update files for the second configured provider #2697

IGassmann opened this issue Mar 15, 2018 · 5 comments

Comments

@IGassmann
Copy link

Autoupdate relies only on the first provider. Thus, there's no need to upload the metadata files for the other configured providers.

It's useful for example when we have GitHub configured as the second provider and we don't want to publish all those metadata files.

@develar
Copy link
Member

develar commented Mar 15, 2018

Interesting... In general you are right.

@IGassmann
Copy link
Author

IGassmann commented Mar 15, 2018

@develar what are the exceptions? If the first provider is down, will it rely on the second one, or that doesn't happen?

@develar
Copy link
Member

develar commented Mar 15, 2018

No, but such implementation can be used by some users. That's why I think it is not safe to do it even if I agree that this behaviour should be by default.

@IGassmann
Copy link
Author

IGassmann commented Mar 15, 2018

I understand. Another idea would be to give an option to specify what provider we want to use for auto-update:

"publish": [
  {
    "provider": "s3",
    "bucket": "my-bucket",
    "path": "app",
    "region": "us-east-1",
    "autoUpdate": "true" // true by default
  },
  {
    "provider": "github",
    ...
    "autoUpdate": "false"
  }
]

@develar
Copy link
Member

develar commented Mar 18, 2018

Option added:

  /**
   * Whether to publish auto update info files.
   *
   * Auto update relies only on the first provider in the list (you can specify several publishers).
   * Thus, probably, there`s no need to upload the metadata files for the other configured providers. But by default will be uploaded.
   *
   * @default true
   */
  readonly publishAutoUpdate?: boolean

to PublishConfiguration.

i.e. as you have suggested, but publishAutoUpdate instead of autoUpdate`. Feel free to discuss the option name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants