-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable 7-zip compression for specific static assets? #2628
Disable 7-zip compression for specific static assets? #2628
Comments
We use solid compression with dictionary size 1 MB (because of differential update).
video? |
@develar In this particular case, it's a VMWare .vmdk file. |
@develar Was your previous comment stating this cannot currently be done? If not, is this issue enough for a feature request? |
Actually, you can do it right now — exclude file and then use custom nsis script to bundle using nsis File command. But it requires deep knowledge and no step by step guide... And actually there is also another internal issue — embedded archive is not extracted directly from exe, instead, it is copied first to temp file. Ok... so, you definitely want this feature and it will be useful for your app, right? Are you commercial company? |
Yes, and yes :) |
Ok, maybe it will be implemented tomorrow CET. |
Dev info: embedding data using our own loader (PE wrapper) implemented in golang is a long-term plan, but for now it is ok just to generate custom file script. Nsis is awesome... but implementing zstd/7za support in C is a very complex task, that is why own golang solution is a better. |
|
@develar In order:
|
@NuSkooler Thanks for answer. So, I think, this feature will break you current usage and you will be forced to use What electron-builder will do: copy file AS-IS to I am not going to put this file to asar.unpacked, but need to investigate — should we to not. Maybe it will allow users to use the same code to access to such file (if asar enabled). |
@GeometricProgress Ouch, actually it is NSIS problem to handle large files, not 7z. |
@GeometricProgress Yeach... Windows PE is limited to 4GB. So, the only solution for you — donate us or wait when solution "golang wrapper and storing app package in the hidden area of exe file" will be implemented. |
I don't want to introduce magic. If you have already compressed files (vm, vides), you should use Option So, as soon as you have specified such files in the
matching files will be copied to app resources and IF file extension matches one of the So, @NuSkooler you need:
|
20.5.0 will be published today. |
Thank you so much again for the quick turn-around on this. Very helpful! |
I have a Electron built application that includes a ~900 MB static asset that already in a compressed format. When building in Linux this is a non-issue, but Windows builds using NSIS want to compress this file which adds a ton of build time (compression) and startup (decompression) time.
Is it possible to disable compression for specific static asset files?
The text was updated successfully, but these errors were encountered: