Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exits with status=0 when signing fails #2538

Closed
salomvary opened this issue Jan 30, 2018 · 4 comments · May be fixed by qcif/data-curator#563
Closed

Exits with status=0 when signing fails #2538

salomvary opened this issue Jan 30, 2018 · 4 comments · May be fixed by qcif/data-curator#563

Comments

@salomvary
Copy link
Contributor

  • Version: 19.55.3
  • Target: macOS

When dist or release fails due to misconfigured code signing certificates the process exits with zero status after printing out the errors. Expected: exit status should be non-zero, signaling a failure.

Example output: https://travis-ci.org/salomvary/soundcleod/builds/335354664

@develar
Copy link
Member

develar commented Jan 30, 2018

Set forceCodeSigning to true.

@salomvary
Copy link
Contributor Author

Set forceCodeSigning to true.

Maybe print this note after the giant red stack trace that follows failure? :)

@salomvary
Copy link
Contributor Author

Actually, it does not seem to build anything (note the absence of "• building ..." lines in the output).

@salomvary
Copy link
Contributor Author

@develar So I have forceCodeSigning set to true and the exit status is still zero despite signing fails die to untrusted certificate. See the output here.

Btw. is there any way to force accepting self-signed certificates on CI? While I can manually set it trusted locally with Keychain Access, not sure what the equivalent of that is in on a CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants