react-scripts dependency excluded from output bundle

[timkendrick]

• Version: 19.52.1

• Target: mac

I'm currently working on an Electron app that allows users to compile their own React projects. One of the dependencies of the app is react-scripts.

I couldn't figure out why the react-scripts dependency was being excluded from the output bundle, even though it is listed as a dependency of the main app (not a devDependency).

After trying all sorts of increasingly crazy attempts to get my project building, I finally managed to track this down to Electron Builder's set of knownAlwaysIgnoredDevDeps in electron-builder-lib/util/packageDependencies.ts. When I manually edit the electron-builder code and remove react-scripts from this set, it is copied into the output correctly.

Does this mean that these exclusions are incorrectly being applied to dependencies, not just devDependencies?

[develar]

Removed from knownAlwaysIgnoredDevDeps.

[timkendrick]

Thanks for the fix!

My only slight concern is that this issue could potentially also apply to any of the other dependencies in that list (e.g. jest).

I guess ideally electron builder could figure out which packages to filter out by checking against the package.json and seeing which are devDependencies and which are dependencies, and not including the devDependencies?

Or alternatively, maybe this list could be configurable so that you can override the default list if your app has unusual requirements?

Thanks for making the fix though, it fixes my problem at least!

[develar]

Why jest can be required?

[timkendrick]

Jest might be required e.g. if you're building a jest test runner GUI app for writing quick TDD-style experiments/fiddles.

I imagine that in this scenario you'd want to bundle the jest library to avoid having to set up a whole new npm project each time you launch the app.

[develar]

Already excluded from list :) Thanks for explanation.