Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github publish asset_already_exists #2094

Closed
peteboothroyd opened this issue Sep 18, 2017 · 0 comments
Closed

Github publish asset_already_exists #2094

peteboothroyd opened this issue Sep 18, 2017 · 0 comments

Comments

@peteboothroyd
Copy link

peteboothroyd commented Sep 18, 2017

Electron-builder: 19.27.7
Electron-builder-http: 19.27.5

Publishing to github fails with an asset already exists error.

I believe the problem is in the githubPublisher file, in the doUpload function. In the catch block

if (e instanceof (_electronBuilderHttp || _load_electronBuilderHttp()).HttpError) 

which evaluates to false when it seems like it should evaluate to true.
Note that for me:
e.response.statusCode = 422, e.description != null, e.description.errors != null, e.description.errors[0].code === "already_exists" and hence the nested if statement below should run.

EDIT:
Upgrading electron-publish to 19.28.1 fixes this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant