Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.20.0 does not read electron-builder.yml #1927

Closed
HitomiTenshi opened this issue Aug 10, 2017 · 5 comments
Closed

v19.20.0 does not read electron-builder.yml #1927

HitomiTenshi opened this issue Aug 10, 2017 · 5 comments
Labels

Comments

@HitomiTenshi
Copy link

HitomiTenshi commented Aug 10, 2017

  • Version: 19.20.0
  • Target: win32 ia32 NSIS

The default config file electron-builder.yml is not being read. I tried changing a bunch of settings because my app was getting extremely huge. Turns out it didn't read the config file and just put all files into the asar package.

Version 19.19.1 works fine.

Edit:
To clarify why I think it is not reading the config file:

I tried to set asar: false and it didn't do anything.

@develar
Copy link
Member

develar commented Aug 10, 2017

Thanks for using prerelease version. I will check.

@develar
Copy link
Member

develar commented Aug 10, 2017

@HitomiTenshi Do you have build in the package.json?

@develar develar added the bug label Aug 10, 2017
@HitomiTenshi
Copy link
Author

Sorry that I couldn't answer in time! No I don't have a "build": "" entry if that's what you mean.

I do have a script that calls build --ia32 though.

@HitomiTenshi
Copy link
Author

Just tested 19.20.1 and the issue is fixed. Thanks for your hard work!

@develar
Copy link
Member

develar commented Aug 11, 2017

I have added unit test to avoid such regressions in the future :) Thanks for confirmation, probably 19.20.1 will be marked as release version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants