Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squirrel Windows and [Content_Types].xml #1803

Closed
lele85 opened this issue Jul 7, 2017 · 2 comments
Closed

Squirrel Windows and [Content_Types].xml #1803

lele85 opened this issue Jul 7, 2017 · 2 comments

Comments

@lele85
Copy link

lele85 commented Jul 7, 2017

I think i found an issue with the generated .nupkg update package when i package my project. The fact is that it seems the tool is generating a generic [Content_Types].xml file not taking in consideration the content of my resources folder.

<?xml version="1.0" encoding="UTF-8"?>
<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types">
    <Default ContentType="application/vnd.openxmlformats-package.relationships+xml" Extension="rels"/>
    <Default ContentType="application/octet" Extension="nuspec"/>
    <Default ContentType="application/octet" Extension="pak"/>
    <Default ContentType="application/octet" Extension="asar"/>
    <Default ContentType="application/octet" Extension="bin"/>
    <Default ContentType="application/octet" Extension="dll"/>
    <Default ContentType="application/octet" Extension="exe"/>
    <Default ContentType="application/octet" Extension="dat"/>
    <Default ContentType="application/vnd.openxmlformats-package.core-properties+xml" Extension="psmdcp"/>
    <Default ContentType="application/octet" Extension="diff"/>
    <Default ContentType="application/octet" Extension="bsdiff"/>
    <Default ContentType="text/plain" Extension="shasum"/>
</Types>

This is the generate file and doesn't take in account that i'm shipping some .mp3 files and a .node one in the app.asar.unpacked folder.

The result is that when the application download and installs the autoupdate these file are not copied in the application folder, resulting in a broken installation.

@develar
Copy link
Member

develar commented Jul 9, 2017

I doubt — this logic for ages and no one report about it.

@lele85
Copy link
Author

lele85 commented Jul 10, 2017

Actually i was quite surprised too. I spent half a day digging in electron-builder and squirrel-windows sources to understand if i was missing something but looks like Content-Types are only added here:

https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder-squirrel-windows/src/squirrelPack.ts#L141

Setting up a test case is quite tricky since i would need to prepare a project, an update nupkg package and host everything somewhere. I can assure the issue exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants