Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file name in latest-mac.json does not match actual file name #1607

Closed
rophy opened this issue Jun 1, 2017 · 7 comments
Closed

file name in latest-mac.json does not match actual file name #1607

rophy opened this issue Jun 1, 2017 · 7 comments

Comments

@rophy
Copy link

rophy commented Jun 1, 2017

  • Version: v18.3.0

  • Target: Mac

relevant contents in package.json:

{
  "name": "my-client",
  "productName": "My Client",
  "version": "1.6.0-SNAPSHOT",
  "build": {
    "appId": "my.client",
    "artifactName": "${name}-${version}-${os}.${ext}",
    "publish": {
      "provider": "generic",
      "url": "http://server.com/updates/${os}",
      "channel": "latest"
    },
   ...
}

After the fix for #1398, the built file name will be: my-client-1.6.0-SNAPSHOT-mac.zip.

Expected generated latest-mac.json:

{
  "version": "1.6.0-SNAPSHOT",
  "releaseDate": "2017-06-01T10:49:27.250Z",
  "url": "http://server.com/updates/mac/my-client-1.6.0-SNAPSHOT-mac"
}

Actual generated latest-mac.json:

{
  "version": "1.6.0-SNAPSHOT",
  "releaseDate": "2017-06-01T10:49:27.250Z",
  "url": "http://server.com/updates/mac/My Client-1.6.0-SNAPSHOT-mac.zip"
}

Problem: since zip file now follows build.artifactName, the URL in latest-mac.json should follow it too.

@bill-pixvana
Copy link

I'm running into the same issue as well. Any update or am I not using the naming conventions correctly?

@develar
Copy link
Member

develar commented Sep 14, 2017

Not fixed yet. As workaround, do not use custom artifactName.

@bill-pixvana
Copy link

I'm using the artifactName to avoid spaces in the productName problem (electron/packager#297). We were seeing updating problems with spaces in the productName.

@develar
Copy link
Member

develar commented Sep 15, 2017

@bill-pixvana thanks for donation. Issue will be fixed 22 September. Do you use electron-updater 2 or 1?

@bill-pixvana
Copy link

Version 2.8 of electron-updater. Thanks for the help

@bill-pixvana
Copy link

@develar Any update on this issue?

@develar
Copy link
Member

develar commented Jan 30, 2018

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants