Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment in electron-builder.json5 blows install/build up #1569

Closed
black-snow opened this issue May 22, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Comment in electron-builder.json5 blows install/build up #1569

black-snow opened this issue May 22, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@black-snow
Copy link
Contributor

black-snow commented May 22, 2017

  • Version: 17.8, 17.10.0
  • Target: appx

Having comments in .json5 should be fine but even npm install fails when I have a comment in my electron-builder.json5.

 install-app-deps
 
YAMLException: missed comma between flow collection entries at line 22, column 3:
      // }
      ^
    at generateError (xyz\node_modules\electron-builder\node_modules\js-yaml\lib\js-yaml\loader.js:162:10)

Building fails as well.

@black-snow
Copy link
Contributor Author

black-snow commented May 23, 2017

@develar We can't use js-yaml for that, do we? json5 comments are javascript-style comments, i. e. // or /**/ whereas yaml comments are #. yaml supports json (no comments at all) but does not support json5.

I'll see if I can file a PR fixing this.

// edit: PR here: #1578

@develar develar added the bug label May 23, 2017
@develar
Copy link
Member

develar commented May 23, 2017

18.0.0 released, thanks for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants