Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product name for linux targets takes from app/package.json, cant change it dynamically #1567

Closed
verget opened this issue May 22, 2017 · 5 comments
Labels

Comments

@verget
Copy link

verget commented May 22, 2017

  • Version: 17.1.2
  • Target: deb

In case of linux data for builds names takes from app/package.json "name" and "version" values unlike of mac and window, where it coming from root package.json. So I can't dynamically change build name like for nsis, for example "build --config.productName=Example"

@verget verget changed the title Product name for linux targets taken from app/package.json, cant change it dynamically Product name for linux targets takes from app/package.json, cant change it dynamically May 22, 2017
@develar
Copy link
Member

develar commented May 22, 2017

Where incorrect name is used?

@verget
Copy link
Author

verget commented May 22, 2017

it's used for build naming, so my example "build --config.productName=Example" - will create on windows build with name "Example-{version}.exe" but on linux it will be "{name-from-app/package.json}-{version}.deb"

@develar
Copy link
Member

develar commented May 22, 2017

By intention. According to Linux convention. See also #775.

@develar develar added the linux label May 22, 2017
@verget
Copy link
Author

verget commented May 22, 2017

Is there some way for dynamically add custom string to linux build names without "app/package.json" change? Im looking for a way to marker my builds depending on git branch from which it made. (dev, prod etc)

@develar
Copy link
Member

develar commented May 22, 2017

#1250 (comment)

--config.extraMetadata.name=newName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants