-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoupdates to lower version with allowPrerelease=true using GitHub releases #1497
Comments
Version check behaves so due to channel concept. But GitHub doesn't support channels... That's bug. |
Can channels be supported on GitHub like on other services by publishing |
Because we ignore version in the channel file. GitHub release version is taken in account. |
Solution — downgrade to stable version must be allowed only and only if |
I think it also should make sure it won't automatically downgrade, only upgrade to the latest stable if allowPrerelease is set to false, by making sure stable version is >= current prerelease version. For example, if I make a channel selector like this: I don't want users to downgrade once they switch back to stable releases, I want them to upgrade to the next stable version once it's released and then keep updating to the next stable, ignoring pre-releases. (Downgrading is usually dangerous due to database migrations, new features, etc.) |
@dchest @tvanro Well, you ask different things/defaults. And I don't want to complicate. |
Thanks! It seems the following algo would work for both our cases when using a pre-release:
|
@dchest Thanks for discussion. Custom logic removed, if you need to allow downgrade — you have to explicitly set |
Awesome, thanks! |
Fixed in [email protected] |
Is there any way to downgrade app to one stable version to the other one? For an example, if I released v1.1.0 and it was buggy and now wants to downgrade to the previous version which was v1.0.0. What combination should I use here? I was hoping |
@akashnimare have you ever found the answer? |
In a test project, I set
autoUpdater.allowPrerelease = true
and published it asv1.16.9-pre
on GitHub as Pre-release. Then publishedv1.17.0-pre
as Pre-release.v1.16.9-pre
successfully autoupdated tov1.17.0-pre
. Then I publishedv1.16.10
(nopre
here) asRelease
(not pre-release) and myv1.17.0-pre
got updated to it, which was unexpected.The chain of updates:
I think somewhere the version check is missing or misbehaving.
The text was updated successfully, but these errors were encountered: