Enable GitHub authentication in Electron Updater

[benmarch]

• Version: 15.0.0

• Electron Updater: 1.8.1

• Target: Mac

After configuring all the publish settings for GitHub Enterprise, I am able to publish updates, but not pull them down using Electron Updater. I receive the following error when calling autoUpdater.checkForUpdates():

Error: Unable to find latest version on GitHub (https://git.mycompany.org/my-organization/content-manager/releases/latest), please ensure a production release exists

When I go to that URL, there is a release available (not a draft or pre-release, a full release). Upon further investigation I discovered that this 404 is due to lack of authentication. GHE expects that all access is authenticated, not just for specific actions like in GitHub hosted.

It would be awesome to be able to pass a Personal Access Token to the request (configured at the time of checking for updates, not packaging) in this form: https://git.mycompany.org/my-organization/content-manager/releases/latest?access_token=xxxxxxx.

If this is an easy fix it would be greatly appreciated. I might recommend using node-github for all GitHub interactions since it seamlessly handles differences between hosted and enterprise versions, as well as offers multiple authentication schemes.

Thank you!

Ben

[develar]

Duplicates #1266

[develar]

Yes, it is easy fix. I am just overloaded.

[benmarch]

I totally understand, thank you!

I can look into a PR if that helps alleviate the load.

[rossanmol]

Would be great to implement this feature.

[AlienHoboken]

@rossanmol @benmarch Just wanted to let you know this is now supported as of electron-updater 1.9.0

[rossanmol]

@AlienHoboken thanks