Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of ArtifactName with Bintray Auto-Update #1305

Closed
naderhen opened this issue Feb 25, 2017 · 6 comments · May be fixed by qcif/data-curator#563
Closed

Usage of ArtifactName with Bintray Auto-Update #1305

naderhen opened this issue Feb 25, 2017 · 6 comments · May be fixed by qcif/data-curator#563

Comments

@naderhen
Copy link
Contributor

  • Electron Builder Version: 14.4.0
  • Electron Updater Version: 1.7.1
  • Target:
    Windows NSIS

Hi, I just wanted to clarify the usage of the relatively new artifactName option that we can now use during the build process. Currently everything works perfectly using Bintray as our publisher (pre custom artifactName), but it seems like it might not take any custom artifact names into account when retrieving the latest update file: https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/BintrayProvider.ts#L36

I may be mistaken, but it seems hardcoded to expect a file named ${AppName} Setup ${Version}.exe.

Is it currently possible to define a custom artifactName with Bintray?

Thanks so much,
Nader

@develar
Copy link
Member

develar commented Feb 26, 2017

What pattern do you use?

@naderhen
Copy link
Contributor Author

naderhen commented Feb 27, 2017

I'm currently using the two package.json structure, targeting Windows with NSIS specifically. I'm experimenting with using electron-builder programmatically (as we deploy to many different environments and configurations in CI) so my config looks more or less like this:

{
    targets: Platform.WINDOWS.createTarget('nsis'),
    config: {
        directories: {
            app: 'electron',
            output: 'release'
        },
        publish: {
            provider: 'bintray',
            user: 'my@email',
            package: 'packagename',
            repo: 'reponame',
            owner: 'mybintrayownername'
        }
    }
};

Please let me know if that answers your question, or if I can provide more information. Thanks again!

@develar
Copy link
Member

develar commented Feb 27, 2017

@naderhen Thanks, could you please specify artifactName that you want to use?

@naderhen
Copy link
Contributor Author

Ideally, it would simply be something like ${AppName}.exe.

@develar
Copy link
Member

develar commented Feb 28, 2017

Ideally, it would simply be something like ${AppName}.exe.

Keep in mind, that Bintray requires file name to be unique across all versions, so, filename should include version.

@develar
Copy link
Member

develar commented Feb 28, 2017

Please try electron-updater 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants