Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Linux: Icon set directory doesn't exist #1276

Closed
cawa-93 opened this issue Feb 19, 2017 · 4 comments · May be fixed by qcif/data-curator#563
Closed

Build for Linux: Icon set directory doesn't exist #1276

cawa-93 opened this issue Feb 19, 2017 · 4 comments · May be fixed by qcif/data-curator#563

Comments

@cawa-93
Copy link
Contributor

cawa-93 commented Feb 19, 2017

  • Version: 13.9.0
  • Target: -l --x64

It seems to me that a relative path is calculated as something strange.
Icons for my application, lie at app/icons
In package.json for Windows I can type

    "win": {
      "icon": "app/icons/icon.ico"
    }

and file will be found
In package.json for Linux I try set:

    "linux": {
      "icon": "app/icons/",
      "target": [
        "AppImage"
      ]
    }

But the builder is looking for them at build/app/icons

I have't build directory.

Unhandled rejection Error: Icon set directory /home/alex/LinWin/Develop/command-editor/build/icons doesn't exist
@develar
Copy link
Member

develar commented Feb 19, 2017

As stated in the docs: The path to icon set directory, relative to build (build resources directory).

But I totally understand you — it is not user-friendly. Because for windows icon also should be relative to build resources, but actually we allow it to be relative or to project dir, or to build.

Fix will be published in 10 minutes.

@develar
Copy link
Member

develar commented Feb 19, 2017

Icon for DMG fixed as well.

@develar
Copy link
Member

develar commented Feb 19, 2017

Please try 13.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants