-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron Builder AutoUpdater download-progress event is not called on MAC. #1167
Comments
FYI: electron-auto-updater renamed to electron-updater. Yes, because under the hood we use native Squirrel.Mac updater and update downloaded by Squirrel.Mac. |
@develar, |
I am not aware about it. You can search / file issue. If Squirrel.Mac developers will reject this idea — probably I can make a PR to Squirrel.Mac. |
Thanks. Issue added: Squirrel/Squirrel.Mac#200 |
No more any difference compared to windows version.
Wants more? Stay tuned — lzma2 instead of zip or even direct support of DMG as update file is coming. Be aware — feedback and testing is wanted. |
what kind of event does the progress fires? |
@biroplane did you find out how to get the download-progress? |
Nope! still trying |
I have the following code working all OK on Windows. I have used mainWindow.setProgressBar to show the progress at the taskbar icon. On MAC auto-update works but without progress. Here is the package.json
Hope this helps you to find some missing pieces. |
@develar I believe this can be closed now - I can verify that I am observing |
Thanks, this works. Now I can use the download-progress event on MacOS also. I can now show the users a good progress bar on Mac. Very helpful. |
How do I show download progress..? I have coded something like this, download works and I am able to restart how do I incorporate progress? `//Single export to check for and apply any available updates. //Check for GH (Releases) //Listern for Update found autoUpdater.on('update-available',(updateInfo)=> { }, buttonIndex => { // If button 0 (Update), Start Download the update if (buttonIndex===0) autoUpdater.downloadUpdate() }) }) //Listen for update Downloaded autoUpdater.on('update-downloaded',() =>{ dialog.showMessageBox({ }, buttonIndex => { //Install and restart if button 0 [Yes] if (buttonIndex === 0) autoUpdater.quitAndInstall(false,true) }) }) }` Please can anyone help ? |
How did you made this work sir. please can you help ? |
Electron Version: 1.4.3
Electron Builder Version: 11.4.4
Target: macOS 10.12.2
Node Version: 7.2.1
NPM Version: 4.1.1
I am trying to use the electron-auto-updater module on MAC. Everything works all OK expect that the
download-progress event of auto updater never gets called.
I have the same solution for Windows and it works perfectly on it.
The text was updated successfully, but these errors were encountered: