From e99047dc69bc7c692ad45cf65ab154a17f594e2b Mon Sep 17 00:00:00 2001 From: develar Date: Tue, 2 Aug 2016 07:50:24 +0200 Subject: [PATCH] feat: Uninstall Confirm Dialog Option for One-click Windows NSIS Closes #618 --- .travis.yml | 1 + package.json | 2 +- templates/nsis/installer.nsi | 8 ++++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1965ac61742..8c4d70421f4 100755 --- a/.travis.yml +++ b/.travis.yml @@ -32,6 +32,7 @@ install: - nvm use --delete-prefix $NODE_VERSION - if [[ "$TRAVIS_OS_NAME" == "osx" && "$NODE_VERSION" == "4" ]]; then npm install npm -g ; fi - npm install +- npm install @develar/semantic-release - npm prune - (cd test/fixtures/app-executable-deps/app && npm install && npm prune) diff --git a/package.json b/package.json index 491b801ce7a..bdc208f1c17 100644 --- a/package.json +++ b/package.json @@ -105,7 +105,7 @@ ] }, "devDependencies": { - "@develar/semantic-release": "^6.3.4", + "@develar/semantic-release": "^6.3.5", "@types/debug": "0.0.28", "@types/mime": "0.0.28", "@types/progress": "^1.1.27", diff --git a/templates/nsis/installer.nsi b/templates/nsis/installer.nsi index 35366ef77b5..d431f3bf9e8 100644 --- a/templates/nsis/installer.nsi +++ b/templates/nsis/installer.nsi @@ -50,6 +50,14 @@ FunctionEnd Function un.onInit !insertmacro check64BitAndSetRegView + + ${IfNot} ${Silent} + MessageBox MB_OKCANCEL "Are you sure you want to uninstall ${PRODUCT_NAME}?" IDOK next + Quit + + next: + ${EndIf} + !insertmacro initMultiUser Un un. !ifmacrodef customUnInit