From d40e0b5922e089606c5fe05f7c8f3c451e4590af Mon Sep 17 00:00:00 2001
From: develar <develar@gmail.com>
Date: Wed, 17 Aug 2016 16:04:29 +0200
Subject: [PATCH] fix: skip rcedit for .msi installer

Close #677
---
 .idea/dictionaries/develar.xml | 1 +
 src/targets/squirrelPack.ts    | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.idea/dictionaries/develar.xml b/.idea/dictionaries/develar.xml
index 44ced67e6a9..eb129700c7e 100644
--- a/.idea/dictionaries/develar.xml
+++ b/.idea/dictionaries/develar.xml
@@ -89,6 +89,7 @@
       <w>progexe</w>
       <w>promisify</w>
       <w>psmdcp</w>
+      <w>rcedit</w>
       <w>readpass</w>
       <w>rels</w>
       <w>repos</w>
diff --git a/src/targets/squirrelPack.ts b/src/targets/squirrelPack.ts
index 377e98c2b69..2db1d6d0610 100644
--- a/src/targets/squirrelPack.ts
+++ b/src/targets/squirrelPack.ts
@@ -99,7 +99,8 @@ export async function buildInstaller(options: SquirrelOptions, outputDirectory:
   if (options.msi && process.platform === "win32") {
     const outFile = setupExe.replace(".exe", ".msi")
     await msi(options, nupkgPath, setupPath, outputDirectory, outFile)
-    await packager.signAndEditResources(path.join(outputDirectory, outFile))
+    // rcedit can only edit .exe resources
+    await packager.sign(path.join(outputDirectory, outFile))
   }
 }