From c4744afe7d12df570ba3012ee74336f9396472e7 Mon Sep 17 00:00:00 2001 From: develar Date: Mon, 6 Mar 2017 10:01:05 +0100 Subject: [PATCH] fix(deployment): disable automatic detection for S3 Close #1334 --- docs/Publishing Artifacts.md | 1 - packages/electron-builder-http/src/publishOptions.ts | 1 - packages/electron-builder/src/publish/PublishManager.ts | 3 --- 3 files changed, 5 deletions(-) diff --git a/docs/Publishing Artifacts.md b/docs/Publishing Artifacts.md index 3398ebdf4d8..f4bfd486a27 100644 --- a/docs/Publishing Artifacts.md +++ b/docs/Publishing Artifacts.md @@ -80,7 +80,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`. If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`. -If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`. Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS). diff --git a/packages/electron-builder-http/src/publishOptions.ts b/packages/electron-builder-http/src/publishOptions.ts index 1be66ff4f4a..3d695b78dda 100644 --- a/packages/electron-builder-http/src/publishOptions.ts +++ b/packages/electron-builder-http/src/publishOptions.ts @@ -7,7 +7,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`. If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`. -If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`. Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS). diff --git a/packages/electron-builder/src/publish/PublishManager.ts b/packages/electron-builder/src/publish/PublishManager.ts index fc1a1b59341..55038022589 100644 --- a/packages/electron-builder/src/publish/PublishManager.ts +++ b/packages/electron-builder/src/publish/PublishManager.ts @@ -368,9 +368,6 @@ export async function getPublishConfigs(packager: PlatformPackager, targetS else if (!isEmptyOrSpaces(process.env.BT_TOKEN)) { serviceName = "bintray" } - else if (!isEmptyOrSpaces(process.env.AWS_ACCESS_KEY_ID) && !isEmptyOrSpaces(process.env.AWS_SECRET_ACCESS_KEY)) { - serviceName = "s3" - } if (serviceName != null) { debug(`Detect ${serviceName} as publish provider`)