From 87300278d24e8304caa4b053b883843a2447dab2 Mon Sep 17 00:00:00 2001 From: matrixbirds <9990676+Matrixbirds@users.noreply.github.com> Date: Sat, 1 Jan 2022 01:02:11 +0800 Subject: [PATCH] fix: add warning to macCodeSign when skipping code signing on M1 macOS device (#6522) On M1 macOS laptop, If you skip code signing, it will cause your bundled macOS app not to work as expected. e.g. - The macOS localization description will not visible in the request permission action. - The macOS request permission grant notify will trigger multiple times --- packages/app-builder-lib/src/codeSign/macCodeSign.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app-builder-lib/src/codeSign/macCodeSign.ts b/packages/app-builder-lib/src/codeSign/macCodeSign.ts index ced91f3b4f5..845864ab652 100644 --- a/packages/app-builder-lib/src/codeSign/macCodeSign.ts +++ b/packages/app-builder-lib/src/codeSign/macCodeSign.ts @@ -67,7 +67,7 @@ export async function reportError( if (qualifier == null) { logFields.reason = "" if (isAutoDiscoveryCodeSignIdentity()) { - logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate`}` + logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible`}` } logFields.reason += ", see https://electron.build/code-signing" if (!isAutoDiscoveryCodeSignIdentity()) {