fix(electron-updater): Do not use multiple HTTP ranges because S3 and…

… Minio doesn't support it

packages/electron-updater/src/AppImageUpdater.ts

@@ -32,7 +32,8 @@ export class AppImageUpdater extends BaseUpdater {
 
   /*** @private */
   protected async doDownloadUpdate(updateInfo: UpdateInfo, cancellationToken: CancellationToken): Promise<Array<string>> {
-    const fileInfo = findFile((await this.provider).resolveFiles(updateInfo), "AppImage")!!
+    const provider = await this.provider
+    const fileInfo = findFile(provider.resolveFiles(updateInfo), "AppImage")!!
 
     const requestHeaders = await this.computeRequestHeaders()
     const downloadOptions: DownloadOptions = {
@@ -62,6 +63,7 @@ export class AppImageUpdater extends BaseUpdater {
           oldPackageFile: oldFile,
           logger: this._logger,
           newFile: installerPath,
+          useMultipleRangeRequest: provider.useMultipleRangeRequest,
           requestHeaders,
         }).download(safeLoad(await readBlockMapDataFromAppImage(oldFile)))
       }

packages/electron-updater/src/GenericProvider.ts

@@ -6,8 +6,8 @@ import { parseUpdateInfo, resolveFiles } from "./Provider"
 export class GenericProvider extends Provider<UpdateInfo> {
   private readonly baseUrl = newBaseUrl(this.configuration.url)
 
-  constructor(private readonly configuration: GenericServerOptions, private readonly updater: AppUpdater) {
-    super(updater.httpExecutor)
+  constructor(private readonly configuration: GenericServerOptions, private readonly updater: AppUpdater, useMultipleRangeRequest = true) {
+    super(updater.httpExecutor, useMultipleRangeRequest)
   }
 
   private get channel(): string {

packages/electron-updater/src/NsisUpdater.ts

@@ -1,13 +1,13 @@
-import { CancellationToken, DownloadOptions, AllPublishOptions, UpdateInfo } from "builder-util-runtime"
+import { AllPublishOptions, CancellationToken, DownloadOptions, UpdateInfo } from "builder-util-runtime"
 import { BLOCK_MAP_FILE_NAME } from "builder-util-runtime/out/blockMapApi"
 import { spawn } from "child_process"
 import * as path from "path"
 import "source-map-support/register"
+import { BaseUpdater } from "./BaseUpdater"
 import { SevenZipDifferentialDownloader } from "./differentialDownloader/SevenZipDifferentialDownloader"
 import { UPDATE_DOWNLOADED } from "./main"
-import { verifySignature } from "./windowsExecutableCodeSignatureVerifier"
-import { BaseUpdater } from "./BaseUpdater"
 import { findFile } from "./Provider"
+import { verifySignature } from "./windowsExecutableCodeSignatureVerifier"
 
 export class NsisUpdater extends BaseUpdater {
   constructor(options?: AllPublishOptions | null, app?: any) {
@@ -16,7 +16,8 @@ export class NsisUpdater extends BaseUpdater {
 
   /*** @private */
   protected async doDownloadUpdate(updateInfo: UpdateInfo, cancellationToken: CancellationToken): Promise<Array<string>> {
-    const fileInfo = findFile((await this.provider).resolveFiles(updateInfo), "exe")!!
+    const provider = await this.provider
+    const fileInfo = findFile(provider.resolveFiles(updateInfo), "exe")!!
     const requestHeaders = await this.computeRequestHeaders()
     const downloadOptions: DownloadOptions = {
       skipDirCreation: true,
@@ -51,6 +52,7 @@ export class NsisUpdater extends BaseUpdater {
               logger: this._logger,
               newFile: packagePath,
               requestHeaders: this.requestHeaders,
+              useMultipleRangeRequest: provider.useMultipleRangeRequest,
             }).download(path.join(process.resourcesPath!, "..", BLOCK_MAP_FILE_NAME))
           }
           catch (e) {

packages/electron-updater/src/Provider.ts

@@ -7,7 +7,7 @@ import { newUrlFromBase, ResolvedUpdateFileInfo } from "./main"
 export abstract class Provider<T extends UpdateInfo> {
   protected requestHeaders: OutgoingHttpHeaders | null
 
-  constructor(protected readonly executor: HttpExecutor<any>) {
+  constructor(protected readonly executor: HttpExecutor<any>, readonly useMultipleRangeRequest = true) {
   }
 
   get fileExtraDownloadHeaders(): OutgoingHttpHeaders | null {

packages/electron-updater/src/differentialDownloader/DifferentialDownloader.ts

@@ -17,6 +17,8 @@ export class DifferentialDownloaderOptions {
   readonly newFile: string
 
   readonly requestHeaders: OutgoingHttpHeaders | null
+
+  readonly useMultipleRangeRequest?: boolean
 }
 
 export abstract class DifferentialDownloader {
@@ -81,7 +83,6 @@ export abstract class DifferentialDownloader {
   }
 
   private async downloadFile(tasks: Array<Operation>): Promise<any> {
-    // todo we can avoid download remote and construct manually
     const signature = this.signatureSize === 0 ? null : await this.readRemoteBytes(0, this.signatureSize - 1)
 
     const oldFileFd = await open(this.options.oldPackageFile, "r")
@@ -129,7 +130,7 @@ export abstract class DifferentialDownloader {
           return
         }
 
-        const nextOffset = taskOffset + 2000
+        const nextOffset = taskOffset + (this.options.useMultipleRangeRequest === false ? 1 : 1000)
         this.executeTasks({
           tasks,
           start: taskOffset,

packages/electron-updater/src/providerFactory.ts

@@ -28,11 +28,11 @@ export function createClient(data: PublishConfiguration | AllPublishOptions, upd
       return new GenericProvider({
         provider: "generic",
         url: getS3LikeProviderBaseUrl(data),
-        channel: (data as BaseS3Options).channel || ""
-      }, updater)
+        channel: (data as BaseS3Options).channel || null
+      }, updater, provider === "spaces" /* https://github.com/minio/minio/issues/5285#issuecomment-350428955 */)
 
     case "generic":
-      return new GenericProvider(data as GenericServerOptions, updater)
+      return new GenericProvider(data as GenericServerOptions, updater, true)
 
     case "bintray":
       return new BintrayProvider(data as BintrayOptions, httpExecutor)

test/src/helpers/updaterTestUtil.ts

@@ -31,6 +31,10 @@ export function createTestApp(version: string, appPath = "") {
       // ignored
     }
 
+    once() {
+      // ignored
+    }
+
     isReady() {
       return true
     }