fix: snap - can't push to snapcraft anymore because of execstack

Close #2608
electron-userland · Feb 20, 2018 · 24f2565 · 24f2565
1 parent 58933e0
commit 24f2565
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/electron-builder-lib/src/linuxPackager.ts b/packages/electron-builder-lib/src/linuxPackager.ts
@@ -1,4 +1,4 @@
-import { Arch, AsyncTaskManager, log } from "builder-util"
+import { Arch, AsyncTaskManager, log, executeAppBuilder } from "builder-util"
 import { rename } from "fs-extra-p"
 import * as path from "path"
 import sanitizeFileName from "sanitize-filename"
@@ -81,8 +81,15 @@ export class LinuxPackager extends PlatformPackager<LinuxConfiguration> {
     }
   }
 
-  protected postInitApp(packContext: AfterPackContext): Promise<any> {
-    return rename(path.join(packContext.appOutDir, this.electronDistExecutableName), path.join(packContext.appOutDir, this.executableName))
+  protected async postInitApp(packContext: AfterPackContext): Promise<void> {
+    const executable = path.join(packContext.appOutDir, this.executableName)
+    await rename(path.join(packContext.appOutDir, this.electronDistExecutableName), executable)
+    try {
+      await executeAppBuilder(["clear-exec-stack", "--input", executable])
+    }
+    catch (e) {
+      log.debug({error: e}, "cannot clear exec stack")
+    }
   }
 }